[jira] [Issue Comment Deleted] (KAFKA-6328) Exclude node groups belonging to global stores in InternalTopologyBuilder#makeNodeGroups

["Richard Yu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Yu updated KAFKA-6328:
------------------------------
    Comment: was deleted

(was: [~guozhang] I have the minor suspicion that global node groups might actually be needed due to the failure of several tests in the QA for my PR. It might be that my approach is wrong. But having checked my code over, I did not spot anything that was out of place. So I think this should warrant some double checking.

Here is the test error:

{panel:title=Test Error for PR#4340}
java.lang.StackOverflowError
	at java.util.HashSet.<init>(HashSet.java:119)
	at org.apache.kafka.streams.processor.internals.InternalTopologyBuilder.makeNodeGroups(InternalTopologyBuilder.java:813)
	at org.apache.kafka.streams.processor.internals.InternalTopologyBuilder.nodeGroups(InternalTopologyBuilder.java:801)
	at org.apache.kafka.streams.processor.internals.InternalTopologyBuilder.globalNodeGroups(InternalTopologyBuilder.java:882)
	at org.apache.kafka.streams.processor.internals.InternalTopologyBuilder.makeNodeGroups(InternalTopologyBuilder.java:814)
	at org.apache.kafka.streams.processor.internals.InternalTopologyBuilder.nodeGroups(InternalTopologyBuilder.java:801)
	at org.apache.kafka.streams.processor.internals.InternalTopologyBuilder.globalNodeGroups(InternalTopologyBuilder.java:882)
        ....
{panel}

)

> Exclude node groups belonging to global stores in InternalTopologyBuilder#makeNodeGroups
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6328
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6328
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Guozhang Wang
>            Assignee: Richard Yu
>              Labels: newbie
>         Attachments: kafka-6328.diff
>
>
> Today when we group processor nodes into groups (i.e. sub-topologies), we assign the sub-topology id for global tables' dummy groups as well. As a result, the subtopology ids (and hence task ids) are not consecutive anymore. This is quite confusing for users trouble shooting and debugging; in addition, the node group for global stores are not useful as well: we simply exclude it in all the caller functions of makeNodeGroups.
> It would be better to simply exclude the global store's node groups in this function so that the subtopology ids and task ids are consecutive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)