[GitHub] [incubator-superset] simchaNielsen commented on pull request #12171: refactor: Sync Scoping tree with Forms data

[GitBox <gi...@apache.org>]

simchaNielsen commented on pull request #12171:
URL: https://github.com/apache/incubator-superset/pull/12171#issuecomment-750115922


   > Can you summarize what are changes made in this PR? filter scope components are shared by filter_box and native filter component, we need to understand why these changes are necessary. thanks!
   
   We build this Scoping tree component instead old one, it placed in ConfigModal for native filters, it duplicates behaviour of old Scoping tree, but save it in `nativeFilters` redux location...
   It's only part of work, we still need connect dashboard charts to this redux location instead old one
   cc @amitmiran137 @villebro 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org