You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/02 19:09:00 UTC
[jira] [Commented] (NIFI-5138) JSON Record Readers providing wrong
schema to sub-records when there is a CHOICE of multiple RECORD types
[ https://issues.apache.org/jira/browse/NIFI-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461505#comment-16461505 ]
ASF GitHub Bot commented on NIFI-5138:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2670
NIFI-5138: Bug fix to ensure that when we have a CHOICE between two o…
…r more REOCRD types that we choose the appropriate RECORD type when creating the Record in the JSON Reader.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5138
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2670
----
commit 0aabaf3348126060cb9281c7d7b109a8428a8f7b
Author: Mark Payne <ma...@...>
Date: 2018-05-02T13:13:52Z
NIFI-5138: Bug fix to ensure that when we have a CHOICE between two or more REOCRD types that we choose the appropriate RECORD type when creating the Record in the JSON Reader.
----
> JSON Record Readers providing wrong schema to sub-records when there is a CHOICE of multiple RECORD types
> ---------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5138
> URL: https://issues.apache.org/jira/browse/NIFI-5138
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
> Fix For: 1.7.0
>
>
> When the JSON Record Reader is used, if the schema provides a CHOICE of two different RECORD types for a sub-record, then the sub-record's schema ends up being an empty schema. This results in RecordPath's not properly evaluating. For example, with the schema below:
> {code:java}
> {
> "name": "top", "namespace": "nifi",
> "type": "record",
> "fields": [
> { "name": "id", "type": "string" },
> { "name": "child", "type": [{
> "name": "first", "type": "record",
> "fields": [{ "name": "name", "type": "string" }]
> }, {
> "name": "second", "type": "record",
> "fields": [{ "name": "id", "type": "string" }]
> }]
> }
> ]
> }{code}
>
> If I then have the following JSON:
> {code:java}
> {
> "id": "1234",
> "child": {
> "id": "4321"
> }
> }{code}
> The result is that the record returned has the correct schema. However, if I then call record.getValue("child") I am returned a Record object that has no schema.
> This results in the RecordPath "/child/id" returning a null value.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)