You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/12 21:31:00 UTC

Review Request 22521: Fixed ZooKeeperProcess and ProcessWatcher to avoid deadlock during ZooKeeperProcess termination.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22521/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Dominic Hamon, and Jiang Yan Xu.


Bugs: MESOS-1477
    https://issues.apache.org/jira/browse/MESOS-1477


Repository: mesos-git


Description
-------

Fixed ZooKeeperProcess and ProcessWatcher to avoid deadlock during ZooKeeperProcess termination.


Diffs
-----

  src/tests/zookeeper.hpp 48844e2d53abcff6664c61f71c2fc9c1b2c536c8 
  src/tests/zookeeper.cpp f5ae23c73b42e270646a7d3fb03f90f198a825c7 
  src/zookeeper/watcher.hpp 0116c9bad2684568ff57380cf093a1367ee92840 
  src/zookeeper/zookeeper.hpp c3c182b6b8258cff965afdb83aa76dd4d6c71b4e 
  src/zookeeper/zookeeper.cpp a35fd50cf2fc3ad9a2ede52c02f22fb65733da76 

Diff: https://reviews.apache.org/r/22521/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 22521: Fixed ZooKeeperProcess and ProcessWatcher to avoid deadlock during ZooKeeperProcess termination.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22521/#review45528
-----------------------------------------------------------

Ship it!


Ship It!

- Jiang Yan Xu


On June 12, 2014, 12:30 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22521/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 12:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1477
>     https://issues.apache.org/jira/browse/MESOS-1477
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixed ZooKeeperProcess and ProcessWatcher to avoid deadlock during ZooKeeperProcess termination.
> 
> 
> Diffs
> -----
> 
>   src/tests/zookeeper.hpp 48844e2d53abcff6664c61f71c2fc9c1b2c536c8 
>   src/tests/zookeeper.cpp f5ae23c73b42e270646a7d3fb03f90f198a825c7 
>   src/zookeeper/watcher.hpp 0116c9bad2684568ff57380cf093a1367ee92840 
>   src/zookeeper/zookeeper.hpp c3c182b6b8258cff965afdb83aa76dd4d6c71b4e 
>   src/zookeeper/zookeeper.cpp a35fd50cf2fc3ad9a2ede52c02f22fb65733da76 
> 
> Diff: https://reviews.apache.org/r/22521/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 22521: Fixed ZooKeeperProcess and ProcessWatcher to avoid deadlock during ZooKeeperProcess termination.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22521/#review45527
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On June 12, 2014, 7:30 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22521/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 7:30 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Dominic Hamon, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1477
>     https://issues.apache.org/jira/browse/MESOS-1477
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixed ZooKeeperProcess and ProcessWatcher to avoid deadlock during ZooKeeperProcess termination.
> 
> 
> Diffs
> -----
> 
>   src/tests/zookeeper.hpp 48844e2d53abcff6664c61f71c2fc9c1b2c536c8 
>   src/tests/zookeeper.cpp f5ae23c73b42e270646a7d3fb03f90f198a825c7 
>   src/zookeeper/watcher.hpp 0116c9bad2684568ff57380cf093a1367ee92840 
>   src/zookeeper/zookeeper.hpp c3c182b6b8258cff965afdb83aa76dd4d6c71b4e 
>   src/zookeeper/zookeeper.cpp a35fd50cf2fc3ad9a2ede52c02f22fb65733da76 
> 
> Diff: https://reviews.apache.org/r/22521/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>