You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/08/01 16:07:27 UTC
[GitHub] flink pull request #2321: [FLINK-4296] Fixes failure reporting of consumer t...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/2321
[FLINK-4296] Fixes failure reporting of consumer task scheduling when producer has already finished
This PR changes the failure behaviour such that the consumer task is failed instead of the
producer task. The latter is problematic, since a finsihed producer task will simply swallow
scheduling exception originating from scheduling the consumer task.
This PR should also be merged in the release-1.1.0 branch.
R @mxm.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixBatchScheduling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2321
----
commit 6eaddb1d562117124e17d244aca69cd591bc9c54
Author: Till Rohrmann <tr...@apache.org>
Date: 2016-08-01T16:05:14Z
[FLINK-4296] Fixes failure reporting of consumer task scheduling when producer has already finished
This PR changes the failure behaviour such that the consumer task is failed instead of the
producer task. The latter is problematic, since a finsihed producer task will simply swallow
scheduling exception originating from scheduling the consumer task.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2321: [FLINK-4296] Fixes failure reporting of consumer task sch...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2321
Good catch. The change and test look good to me! This was broken for a long time (since the initial refactoring of the network stack I think). It never surfaced, because most use cases and tests run with pipelined results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2321: [FLINK-4296] Fixes failure reporting of consumer task sch...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2321
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2321: [FLINK-4296] Fixes failure reporting of consumer t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---