You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/23 10:39:37 UTC

[GitHub] [incubator-echarts] plainheart opened a new pull request #13015: fix(timeline): fix a bug which may bring a crash of browser when using dataURI as icon(#12867).

plainheart opened a new pull request #13015:
URL: https://github.com/apache/incubator-echarts/pull/13015


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   fix the bug which may bring a crash of browser when using dataURI as icon, closes #12867.
   
   ### Fixed issues
   
   - #12867
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   If users specify `timeline.control.controlStyle.playIcon` for a dataURI, it may lead to a crash of the browser.
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   Changed the implement of `makeIcon` to `graphic.createIcon` from `graphic.makePath`.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   Please refer to `test/timeline-dynamic-series.html`.
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   
   N/A.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13015: fix(timeline): fix a bug which may bring a crash of browser when using dataURI as icon(#12867).

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13015:
URL: https://github.com/apache/incubator-echarts/pull/13015#issuecomment-662936320


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #13015: fix(timeline): fix a bug which may bring a crash of browser when using dataURI as icon(#12867).

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13015:
URL: https://github.com/apache/incubator-echarts/pull/13015


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13015: fix(timeline): fix a bug which may bring a crash of browser when using dataURI as icon(#12867).

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13015:
URL: https://github.com/apache/incubator-echarts/pull/13015#issuecomment-663366365


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org