You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "johntor (via GitHub)" <gi...@apache.org> on 2023/01/30 14:03:17 UTC
[GitHub] [netbeans] johntor opened a new pull request, #5390: Fix POM Graph colors for dark themes
johntor opened a new pull request, #5390:
URL: https://github.com/apache/netbeans/pull/5390
I noticed a problem using the Graph of a POM when a dark theme is selected.
The foreground color was requested from the Theme while backgrounds are hardcoded into the Class causing printing WHITE on Bright Colors.
With this fix I added transparency to these hardcoded colors so the become darker on darker backgrounds.
I also removed gradients that looked a bit outdated to my eyes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] johntor commented on pull request #5390: Fix POM Graph colors for dark themes
Posted by "johntor (via GitHub)" <gi...@apache.org>.
johntor commented on PR #5390:
URL: https://github.com/apache/netbeans/pull/5390#issuecomment-1408743681
Moved to the delivery branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] johntor closed pull request #5390: Fix POM Graph colors for dark themes
Posted by "johntor (via GitHub)" <gi...@apache.org>.
johntor closed pull request #5390: Fix POM Graph colors for dark themes
URL: https://github.com/apache/netbeans/pull/5390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5390: Fix POM Graph colors for dark themes
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5390:
URL: https://github.com/apache/netbeans/pull/5390#issuecomment-1408707571
Thanks for the fix! Can you make your commit on top of the delivery branch instead of master, and force push an update? Or open another PR if easier. This is a potential fix to squeeze in the next release, which forked off a couple of weeks back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists