You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/10 20:46:45 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new issue #20511: License issue with src/operator/contrib/erfinv-inl.h
mseth10 opened a new issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511
This file has a comment that states "Code is a direct translation of the erfinv m file in matlab version 2.0.”
https://github.com/apache/incubator-mxnet/blob/dba682a57812b49a222c04297224921393ea90bb/src/operator/contrib/erfinv-inl.h#L61-L62
Since Matlab is not open source software, it's basically a Category X software.
#### Proposed Solution
There are two commonly used methods for implementing the inverse error function:
- Initial approximation followed by two steps of Newton's method
- Used by MATLAB (current implementation) - Category X license
- Also used by Scilab (GPL license - also Category X): https://github.com/scilab/scilab/blob/master/scilab/modules/special_functions/macros/erfinv.sci
- Rational approximation of percentage points of normal distribution
Used by SciPy (new BSD license): https://github.com/scipy/scipy/blob/master/scipy/special/cephes/erfinv.c
We can modify MXNet's `erfinv` function to use SciPy's implementation as SciPy's license is Apache compliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] mseth10 closed issue #20511: 2. Two issues raised with src/operator/contrib/erfinv-inl.h:
Posted by GitBox <gi...@apache.org>.
mseth10 closed issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on issue #20511: License issue with src/operator/contrib/erfinv-inl.h
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511#issuecomment-899352217
Fixed by #20517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] szha commented on issue #20511: License issue with src/operator/contrib/erfinv-inl.h
Posted by GitBox <gi...@apache.org>.
szha commented on issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511#issuecomment-896479831
I don't recall if we have one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on issue #20511: License issue with src/operator/contrib/erfinv-inl.h
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511#issuecomment-896323651
> Is the performance comparable between the translated solution and the scipy's implementation?
I can check for performance after getting SciPy's implementation to work and then post the results here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] mseth10 closed issue #20511: License issue with src/operator/contrib/erfinv-inl.h
Posted by GitBox <gi...@apache.org>.
mseth10 closed issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on issue #20511: License issue with src/operator/contrib/erfinv-inl.h
Posted by GitBox <gi...@apache.org>.
mseth10 commented on issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511#issuecomment-896371299
Do we have inverse normal distribution function in MXNet? Something similar to https://github.com/scipy/scipy/blob/master/scipy/special/cephes/ndtri.c @szha @leezu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] szha commented on issue #20511: License issue with src/operator/contrib/erfinv-inl.h
Posted by GitBox <gi...@apache.org>.
szha commented on issue #20511:
URL: https://github.com/apache/incubator-mxnet/issues/20511#issuecomment-896312213
Is the performance comparable between the translated solution and the scipy's implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org