[GitHub] [spark] ulysses-you commented on a diff in pull request #33522: [SPARK-36290][SQL] Pull out join condition

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #33522:
URL: https://github.com/apache/spark/pull/33522#discussion_r897875181


##########
sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala:
##########
@@ -1057,7 +1057,7 @@ class JoinSuite extends QueryTest with SharedSparkSession with AdaptiveSparkPlan
     val pythonEvals = collect(joinNode.get) {
       case p: BatchEvalPythonExec => p
     }
-    assert(pythonEvals.size == 2)
+    assert(pythonEvals.size == 4)

Review Comment:
   @wangyum @cloud-fan Seems we can just put the rule after `InferFiltersFromConstraints`, and actually after the `earlyScanPushDownRules`. The python UDF test passed in my pr, see https://github.com/apache/spark/pull/36874.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org