[jira] [Commented] (MAPREDUCE-2649) MR279: Fate of finished Applications on RM

["Robert Joseph Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078308#comment-13078308 ] 

Robert Joseph Evans commented on MAPREDUCE-2649:
------------------------------------------------

Just a few comments about the patch.  

This is very minor but it would be good to make APPLICATION_FINISHTIME_COMPARATOR a static inner class of ApplicationsManagerImpl instead of an anonymous class.  It reduces the amount of unused data in the class, even though it is only instantiated once.

There is no error handling on RetireApplicationsThread.  If an Error or RuntimeException occurs then the thread will die silently.  However I cannot find an example of how it should be handled in the YARN code, so it might be fine the way it is.

> MR279: Fate of finished Applications on RM
> ------------------------------------------
>
>                 Key: MAPREDUCE-2649
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2649
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2649-patch-mr279.txt
>
>
> Today RM keeps the references of finished application for ever. Though this is not sustainable long term, it keeps
> the user experience saner. Users can revisit RM UI and check the status of their apps.
> We need to think of purging old references yet keeping the UX sane.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira