[GitHub] [spark] mridulm commented on a diff in pull request #39093: [SPARK-41420][UI] Protobuf serializer for ApplicationInfoWrapper

[GitBox <gi...@apache.org>]

mridulm commented on code in PR #39093:
URL: https://github.com/apache/spark/pull/39093#discussion_r1051020503


##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -106,3 +106,28 @@ message TaskDataWrapper {
   int64 stage_id = 40;
   int32 stage_attempt_id = 41;
 }
+
+message ApplicationAttemptInfo {
+  optional string attempt_id = 1;
+  int64 start_time = 2;
+  int64 end_time = 3;
+  int64 last_updated = 4;
+  int64 duration = 5;
+  string spark_user = 6;
+  bool completed = 7;
+  string app_spark_version = 8;
+}
+
+message ApplicationInfo {
+  string id = 1;
+  string name = 2;
+  optional int32 cores_granted = 3;
+  optional int32 max_cores = 4;
+  optional int32 cores_per_executor = 5;
+  optional int32 memory_per_executor_mb = 6;
+  repeated ApplicationAttemptInfo attempts = 7;
+}
+
+message ApplicationInfoWrapper {
+  ApplicationInfo info = 1;

Review Comment:
   Missing `AttemptInfoWrapper` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org