You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/19 16:19:41 UTC

[GitHub] [spark] srowen commented on a change in pull request #24409: [SPARK-27513][BUILD] files in tarball should have uid/gid 0

srowen commented on a change in pull request #24409: [SPARK-27513][BUILD] files in tarball should have uid/gid 0
URL: https://github.com/apache/spark/pull/24409#discussion_r277027489
 
 

 ##########
 File path: dev/make-distribution.sh
 ##########
 @@ -286,6 +286,6 @@ if [ "$MAKE_TGZ" == "true" ]; then
   TARDIR="$SPARK_HOME/$TARDIR_NAME"
   rm -rf "$TARDIR"
   cp -r "$DISTDIR" "$TARDIR"
-  tar czf "spark-$VERSION-bin-$NAME.tgz" -C "$SPARK_HOME" "$TARDIR_NAME"
 
 Review comment:
   Ah, this is a gnu vs BSD tar thing, darn. I don't see any equivalent on OS X and yeah we don't want to make this fail on Macs.
   Can you use -o when extracting the archive as root to avoid this instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org