[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5709: arch/riscv/src/mpfs: Make cleaner pinmux configurations for USB

[GitBox <gi...@apache.org>]

jlaitine commented on a change in pull request #5709:
URL: https://github.com/apache/incubator-nuttx/pull/5709#discussion_r824135753



##########
File path: arch/risc-v/src/mpfs/hardware/mpfs250t_484_pinmap.h
##########
@@ -130,6 +131,21 @@
 #define MSSIO_GPIO_PAD36_E3 (GPIO_BANK1 | GPIO_PIN22 | MSSIO_AF_GPIO | MSSIO_EC_DEFAULT)
 #define MSSIO_GPIO_PAD37_D4 (GPIO_BANK1 | GPIO_PIN23 | MSSIO_AF_GPIO | MSSIO_EC_DEFAULT)
 
+/* USB pins */
+
+#define MSSIO_USB_CLK (GPIO_BANK1 | GPIO_PIN0  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DIR (GPIO_BANK1 | GPIO_PIN1  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_NXT (GPIO_BANK1 | GPIO_PIN2  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_STP (GPIO_BANK1 | GPIO_PIN3  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA0 (GPIO_BANK1 | GPIO_PIN4  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA1 (GPIO_BANK1 | GPIO_PIN5  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA2 (GPIO_BANK1 | GPIO_PIN6  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA3 (GPIO_BANK1 | GPIO_PIN7  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA4 (GPIO_BANK1 | GPIO_PIN8  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA5 (GPIO_BANK1 | GPIO_PIN9  | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA6 (GPIO_BANK1 | GPIO_PIN10 | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)
+#define MSSIO_USB_DATA7 (GPIO_BANK1 | GPIO_PIN11 | MSSIO_AF_USB | MSSIO_EC_USB_DEFAULT)

Review comment:
       sure, done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org