You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/12 02:54:13 UTC
[GitHub] [hbase] Apache9 opened a new pull request #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Apache9 opened a new pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r383986883
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
Review comment:
Ok. So, your argument is that folks using current data structures and methods will have an easier time if the names of methods, etc., have same basic pattern in the new context.
Ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-591197401
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 5s | https://github.com/apache/hbase/pull/1165 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/6/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-591580475
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 54s | master passed |
| +1 :green_heart: | compile | 3m 22s | master passed |
| +1 :green_heart: | checkstyle | 2m 47s | master passed |
| +1 :green_heart: | shadedjars | 5m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 15s | master passed |
| +0 :ok: | spotbugs | 1m 26s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 14s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 36s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 52s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 37s | the patch passed |
| +1 :green_heart: | compile | 3m 22s | the patch passed |
| +1 :green_heart: | cc | 3m 22s | the patch passed |
| +1 :green_heart: | javac | 3m 22s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 40s | root: The patch generated 0 new + 707 unchanged - 22 fixed = 707 total (was 729) |
| +1 :green_heart: | rubocop | 0m 13s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 15s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 28s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 12m 17s | the patch passed |
| +1 :green_heart: | javadoc | 5m 56s | the patch passed |
| +0 :ok: | findbugs | 0m 12s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 33s | hbase-assembly has no data from findbugs |
| -1 :x: | findbugs | 9m 38s | root in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 151m 6s | root in the patch passed. |
| +1 :green_heart: | asflicense | 4m 23s | The patch does not generate ASF License warnings. |
| | | 299m 25s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/8/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop |
| uname | Linux 7810253dd259 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / 3c3aae9a2f |
| Default Java | 1.8.0_181 |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/8/artifact/out/patch-findbugs-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/8/testReport/ |
| Max. process+thread count | 6653 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/8/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r378440187
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given group name
+ * @param groupName the group name
+ * @return group info
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given hostPort
+ * @param hostPort HostPort to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(Address hostPort) throws IOException;
+
+ /**
+ * Get group info for the given table
+ * @param tableName table name to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(TableName tableName) throws IOException;
+
+ /**
+ * Lists current set of RegionServer groups
+ * @throws IOException if a remote or network exception occurs
+ */
+ List<RSGroupInfo> listRSGroups() throws IOException;
+
+ /**
+ * Get all tables in this RegionServer group.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #getConfiguredNamespacesAndTablesInRSGroup(String)
+ */
+ List<TableName> listTablesInRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get the namespaces and tables which have this RegionServer group in descriptor.
+ * <p/>
+ * The difference between this method and {@link #listTablesInRSGroup(String)} is that, this
+ * method will not include the table which is actually in this RegionServr group but without the
+ * RegionServer group configuration in its {@link TableDescriptor}. For example, we have a group
+ * 'A', and we make namespace 'nsA' in this group, then all the tables under this namespace will
+ * in the group 'A', but this method will not return these tables but only the namespace 'nsA',
+ * while the {@link #listTablesInRSGroup(String)} will return all these tables.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #listTablesInRSGroup(String)
+ */
+ Pair<List<String>, List<TableName>> getConfiguredNamespacesAndTablesInRSGroup(String groupName)
Review comment:
Purge 'Configured' from this method name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-590907554
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 49s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 19s | master passed |
| +1 :green_heart: | compile | 3m 3s | master passed |
| +1 :green_heart: | checkstyle | 2m 36s | master passed |
| +1 :green_heart: | shadedjars | 4m 41s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 19s | master passed |
| +0 :ok: | spotbugs | 1m 22s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 15s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 32s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 56s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 2s | the patch passed |
| +1 :green_heart: | compile | 3m 2s | the patch passed |
| +1 :green_heart: | cc | 3m 2s | the patch passed |
| +1 :green_heart: | javac | 3m 2s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 32s | root: The patch generated 0 new + 733 unchanged - 22 fixed = 733 total (was 755) |
| +1 :green_heart: | rubocop | 0m 9s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 45s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 10m 13s | the patch passed |
| +1 :green_heart: | javadoc | 6m 5s | the patch passed |
| +0 :ok: | findbugs | 0m 13s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 31s | hbase-assembly has no data from findbugs |
||| _ Other Tests _ |
| -1 :x: | unit | 69m 2s | root in the patch failed. |
| +1 :green_heart: | asflicense | 5m 37s | The patch does not generate ASF License warnings. |
| | | 209m 44s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsBasics |
| | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop |
| uname | Linux 310d05e52bd6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / 3e21dc73de |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/5/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/5/testReport/ |
| Max. process+thread count | 8897 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/5/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r384377492
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
##########
@@ -87,7 +102,7 @@ public boolean containsServer(Address hostPort) {
/**
* Get list of servers.
*/
- public Set<Address> getServers() {
+ public SortedSet<Address> getServers() {
Review comment:
I think this one is fine? SortedSet is Set, and this is a new major release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r378448167
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -3498,13 +3511,13 @@ public SplitOrMergeTracker getSplitOrMergeTracker() {
}
@Override
- public LoadBalancer getLoadBalancer() {
+ public RSGroupBasedLoadBalancer getLoadBalancer() {
Review comment:
Yeah, can't just return 'LoadBalancer' only now LB handles RSGroups too? (Maybe not possible for RSGroupLB...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1165: HBASE-22514 Move rsgroup
feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-590714113
OK I think it is a problem introduced by the newly introduced master based meta look up feature. If I shutdown the running master and start a new one, then I must recreate the hbase client as it only records the old master address so it will not send request to the new one and cause the client to retry for ever...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #1165: HBASE-22514 Move rsgroup
feature into core of HBase
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-589975448
Unit test failures look related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-589970621
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 47s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 14s | master passed |
| +1 :green_heart: | compile | 3m 4s | master passed |
| +1 :green_heart: | checkstyle | 2m 34s | master passed |
| +1 :green_heart: | shadedjars | 4m 40s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 20s | master passed |
| +0 :ok: | spotbugs | 1m 21s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 16s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 32s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 55s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 2s | the patch passed |
| +1 :green_heart: | compile | 3m 4s | the patch passed |
| +1 :green_heart: | cc | 3m 4s | the patch passed |
| +1 :green_heart: | javac | 3m 4s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 27s | root: The patch generated 0 new + 733 unchanged - 22 fixed = 733 total (was 755) |
| +1 :green_heart: | rubocop | 0m 9s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 10m 25s | the patch passed |
| +1 :green_heart: | javadoc | 6m 3s | the patch passed |
| +0 :ok: | findbugs | 0m 13s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 30s | hbase-assembly has no data from findbugs |
||| _ Other Tests _ |
| -1 :x: | unit | 69m 35s | root in the patch failed. |
| +1 :green_heart: | asflicense | 5m 38s | The patch does not generate ASF License warnings. |
| | | 210m 7s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsBasics |
| | hadoop.hbase.rsgroup.TestMigrateRSGroupInfo |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop |
| uname | Linux 3f5aa5697a69 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / 400b7ce954 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/3/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/3/testReport/ |
| Max. process+thread count | 8543 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r378439617
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
Review comment:
Hmm... Yeah, Group is too generic so s/RS/RegionGroup/ ? Big change I suppose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r378601572
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given group name
+ * @param groupName the group name
+ * @return group info
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given hostPort
+ * @param hostPort HostPort to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(Address hostPort) throws IOException;
+
+ /**
+ * Get group info for the given table
+ * @param tableName table name to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(TableName tableName) throws IOException;
+
+ /**
+ * Lists current set of RegionServer groups
+ * @throws IOException if a remote or network exception occurs
+ */
+ List<RSGroupInfo> listRSGroups() throws IOException;
+
+ /**
+ * Get all tables in this RegionServer group.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #getConfiguredNamespacesAndTablesInRSGroup(String)
+ */
+ List<TableName> listTablesInRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get the namespaces and tables which have this RegionServer group in descriptor.
+ * <p/>
+ * The difference between this method and {@link #listTablesInRSGroup(String)} is that, this
+ * method will not include the table which is actually in this RegionServr group but without the
+ * RegionServer group configuration in its {@link TableDescriptor}. For example, we have a group
+ * 'A', and we make namespace 'nsA' in this group, then all the tables under this namespace will
+ * in the group 'A', but this method will not return these tables but only the namespace 'nsA',
+ * while the {@link #listTablesInRSGroup(String)} will return all these tables.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #listTablesInRSGroup(String)
+ */
+ Pair<List<String>, List<TableName>> getConfiguredNamespacesAndTablesInRSGroup(String groupName)
Review comment:
But it is the 'configured' namespaces and tables. For example, you have namespace 'N' under rs group 'R', this method will only return namespace 'N', and will not return the tables under namespace 'N'...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1165: HBASE-22514 Move rsgroup
feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-591741976
The find bugs error is OOM...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-592909616
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 47s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 17s | master passed |
| +1 :green_heart: | compile | 3m 4s | master passed |
| +1 :green_heart: | checkstyle | 2m 34s | master passed |
| +0 :ok: | refguide | 4m 50s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 4m 45s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 18s | master passed |
| +0 :ok: | spotbugs | 1m 19s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 17s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 33s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 54s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 3s | the patch passed |
| +1 :green_heart: | compile | 3m 9s | the patch passed |
| +1 :green_heart: | cc | 3m 9s | the patch passed |
| +1 :green_heart: | javac | 3m 9s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 28s | root: The patch generated 0 new + 707 unchanged - 22 fixed = 707 total (was 729) |
| +1 :green_heart: | rubocop | 0m 11s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| +0 :ok: | refguide | 4m 44s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. |
| +1 :green_heart: | shadedjars | 4m 48s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 10m 21s | the patch passed |
| +1 :green_heart: | javadoc | 6m 5s | the patch passed |
| +0 :ok: | findbugs | 0m 13s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 30s | hbase-assembly has no data from findbugs |
| -1 :x: | findbugs | 8m 42s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 117m 14s | root in the patch failed. |
| +1 :green_heart: | asflicense | 6m 5s | The patch does not generate ASF License warnings. |
| | | 263m 33s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.thrift2.TestThriftHBaseServiceHandler |
| | hadoop.hbase.backup.TestIncrementalBackup |
| | hadoop.hbase.backup.TestRemoteRestore |
| | hadoop.hbase.backup.TestBackupShowHistory |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/10/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop refguide |
| uname | Linux 13b11fce51b3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / a420f0482e |
| Default Java | 1.8.0_181 |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/10/artifact/out/branch-site/book.html |
| refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/10/artifact/out/patch-site/book.html |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/10/artifact/out/patch-findbugs-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/10/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/10/testReport/ |
| Max. process+thread count | 9896 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/10/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #1165: HBASE-22514 Move rsgroup
feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-590811546
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 47s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 6m 26s | master passed |
| +1 :green_heart: | compile | 3m 30s | master passed |
| +1 :green_heart: | checkstyle | 3m 3s | master passed |
| +1 :green_heart: | shadedjars | 5m 39s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 25s | master passed |
| +0 :ok: | spotbugs | 1m 22s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 16s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 34s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 56s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 7s | the patch passed |
| +1 :green_heart: | compile | 3m 1s | the patch passed |
| +1 :green_heart: | cc | 3m 1s | the patch passed |
| +1 :green_heart: | javac | 3m 1s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 30s | root: The patch generated 0 new + 733 unchanged - 22 fixed = 733 total (was 755) |
| +1 :green_heart: | rubocop | 0m 12s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 41s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 10m 33s | the patch passed |
| +1 :green_heart: | javadoc | 6m 6s | the patch passed |
| +0 :ok: | findbugs | 0m 13s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 30s | hbase-assembly has no data from findbugs |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 21s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 33s | The patch does not generate ASF License warnings. |
| | | 142m 44s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop |
| uname | Linux 226d43394fb3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / 3e21dc73de |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/4/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/4/testReport/ |
| Max. process+thread count | 595 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/4/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-585080980
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 41s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 50s | master passed |
| +1 :green_heart: | compile | 3m 19s | master passed |
| +1 :green_heart: | checkstyle | 2m 47s | master passed |
| +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 10s | master passed |
| +0 :ok: | spotbugs | 1m 25s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 14s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 33s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 52s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 39s | the patch passed |
| +1 :green_heart: | compile | 3m 22s | the patch passed |
| +1 :green_heart: | cc | 3m 22s | the patch passed |
| +1 :green_heart: | javac | 3m 22s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 43s | root: The patch generated 0 new + 756 unchanged - 22 fixed = 756 total (was 778) |
| +1 :green_heart: | rubocop | 0m 10s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 7s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 53s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 11m 30s | the patch passed |
| +1 :green_heart: | javadoc | 6m 43s | the patch passed |
| +0 :ok: | findbugs | 0m 12s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 45s | hbase-assembly has no data from findbugs |
||| _ Other Tests _ |
| -1 :x: | unit | 135m 49s | root in the patch failed. |
| +1 :green_heart: | asflicense | 4m 25s | The patch does not generate ASF License warnings. |
| | | 304m 21s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.quotas.TestClusterScopeQuotaThrottle |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop |
| uname | Linux c6705bf6ff4a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / 12f98bc50e |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/1/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/1/testReport/ |
| Max. process+thread count | 5667 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.79.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-591428088
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 0s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 55s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 19s | master passed |
| +1 :green_heart: | compile | 3m 8s | master passed |
| +1 :green_heart: | checkstyle | 2m 33s | master passed |
| +1 :green_heart: | shadedjars | 4m 45s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 22s | master passed |
| +0 :ok: | spotbugs | 1m 22s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 16s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 31s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 56s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 1s | the patch passed |
| +1 :green_heart: | compile | 3m 3s | the patch passed |
| +1 :green_heart: | cc | 3m 3s | the patch passed |
| +1 :green_heart: | javac | 3m 3s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 28s | root: The patch generated 0 new + 707 unchanged - 22 fixed = 707 total (was 729) |
| +1 :green_heart: | rubocop | 0m 11s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 45s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 55s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 10m 21s | the patch passed |
| +1 :green_heart: | javadoc | 6m 2s | the patch passed |
| +0 :ok: | findbugs | 0m 12s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 31s | hbase-assembly has no data from findbugs |
| -1 :x: | findbugs | 8m 52s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 19s | root in the patch failed. |
| +1 :green_heart: | asflicense | 2m 24s | The patch does not generate ASF License warnings. |
| | | 133m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/7/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop |
| uname | Linux b466019ba3d7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / ecbed33092 |
| Default Java | 1.8.0_181 |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/7/artifact/out/patch-findbugs-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/7/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/7/testReport/ |
| Max. process+thread count | 614 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/7/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r384380987
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given group name
+ * @param groupName the group name
+ * @return group info
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given hostPort
+ * @param hostPort HostPort to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(Address hostPort) throws IOException;
+
+ /**
+ * Get group info for the given table
+ * @param tableName table name to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(TableName tableName) throws IOException;
+
+ /**
+ * Lists current set of RegionServer groups
+ * @throws IOException if a remote or network exception occurs
+ */
+ List<RSGroupInfo> listRSGroups() throws IOException;
+
+ /**
+ * Get all tables in this RegionServer group.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #getConfiguredNamespacesAndTablesInRSGroup(String)
+ */
+ List<TableName> listTablesInRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get the namespaces and tables which have this RegionServer group in descriptor.
+ * <p/>
+ * The difference between this method and {@link #listTablesInRSGroup(String)} is that, this
+ * method will not include the table which is actually in this RegionServr group but without the
+ * RegionServer group configuration in its {@link TableDescriptor}. For example, we have a group
+ * 'A', and we make namespace 'nsA' in this group, then all the tables under this namespace will
+ * in the group 'A', but this method will not return these tables but only the namespace 'nsA',
+ * while the {@link #listTablesInRSGroup(String)} will return all these tables.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #listTablesInRSGroup(String)
+ */
+ Pair<List<String>, List<TableName>> getConfiguredNamespacesAndTablesInRSGroup(String groupName)
Review comment:
There is a listTablesInRSGroup method above, which will all the tables in the rs group, including the tables which are included becasue of their namespace is configued to be in the rs group...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-589064923
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | prototool | 0m 1s | prototool was not available. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 47 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 45s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 45s | master passed |
| +1 :green_heart: | compile | 3m 19s | master passed |
| +1 :green_heart: | checkstyle | 2m 46s | master passed |
| +1 :green_heart: | shadedjars | 5m 7s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 6m 13s | master passed |
| +0 :ok: | spotbugs | 1m 29s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 14s | branch/hbase-annotations no findbugs output file (findbugsXml.xml) |
| +0 :ok: | findbugs | 0m 32s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 2m 52s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 35s | the patch passed |
| +1 :green_heart: | compile | 3m 20s | the patch passed |
| +1 :green_heart: | cc | 3m 20s | the patch passed |
| +1 :green_heart: | javac | 3m 20s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 42s | root: The patch generated 0 new + 733 unchanged - 22 fixed = 733 total (was 755) |
| +1 :green_heart: | rubocop | 0m 11s | There were no new rubocop issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 8s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 40s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | hbaseprotoc | 10m 56s | the patch passed |
| +1 :green_heart: | javadoc | 5m 54s | the patch passed |
| +0 :ok: | findbugs | 0m 11s | hbase-annotations has no data from findbugs |
| +0 :ok: | findbugs | 0m 31s | hbase-assembly has no data from findbugs |
||| _ Other Tests _ |
| -1 :x: | unit | 121m 25s | root in the patch failed. |
| +1 :green_heart: | asflicense | 4m 31s | The patch does not generate ASF License warnings. |
| | | 271m 49s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient |
| | hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient |
| | hadoop.hbase.rsgroup.TestMigrateRSGroupInfo |
| | hadoop.hbase.master.procedure.TestSCPWithReplicasWithRSGroup |
| | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc prototool rubocop |
| uname | Linux cfc75bfcae88 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1165/out/precommit/personality/provided.sh |
| git revision | master / fe0d49bc52 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/2/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/2/testReport/ |
| Max. process+thread count | 7201 (vs. ulimit of 10000) |
| modules | C: hbase-annotations hbase-protocol-shaded hbase-common hbase-protocol hbase-client hbase-server hbase-thrift hbase-shell hbase-it hbase-assembly . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.80.0 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r378438971
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
Review comment:
Do we still need 'RS'? Should this be addGroup or addRegionServerGroup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r382918299
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
##########
@@ -87,7 +102,7 @@ public boolean containsServer(Address hostPort) {
/**
* Get list of servers.
*/
- public Set<Address> getServers() {
+ public SortedSet<Address> getServers() {
Review comment:
Can we avoid changing the method signature on this IA.Public method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1165: HBASE-22514 Move rsgroup
feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-590079306
> Unit test failures look related?
Let me take a look. All the UTs are not in a good state recently, even for master, the flakey job list are increased a lot...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1165: HBASE-22514 Move rsgroup
feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-590726279
https://github.com/apache/hbase/pull/1205
Plan to switch back to ZKConnectionRegistry first.
Let me open an issue for the ref guide update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1165: HBASE-22514 Move
rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#issuecomment-592909910
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | patch | 0m 5s | https://github.com/apache/hbase/pull/1165 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/1165 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1165/11/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r378601730
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
Review comment:
The IA.Public data structure is call RSGroupInfo so...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r383988388
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -2262,4 +2265,104 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)
*/
boolean isSnapshotCleanupEnabled() throws IOException;
+ /**
+ * Creates a new RegionServer group with the given name
+ * @param groupName the name of the group
+ * @throws IOException if a remote or network exception occurs
+ */
+ void addRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given group name
+ * @param groupName the group name
+ * @return group info
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get group info for the given hostPort
+ * @param hostPort HostPort to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(Address hostPort) throws IOException;
+
+ /**
+ * Get group info for the given table
+ * @param tableName table name to get RSGroupInfo for
+ * @throws IOException if a remote or network exception occurs
+ */
+ RSGroupInfo getRSGroup(TableName tableName) throws IOException;
+
+ /**
+ * Lists current set of RegionServer groups
+ * @throws IOException if a remote or network exception occurs
+ */
+ List<RSGroupInfo> listRSGroups() throws IOException;
+
+ /**
+ * Get all tables in this RegionServer group.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #getConfiguredNamespacesAndTablesInRSGroup(String)
+ */
+ List<TableName> listTablesInRSGroup(String groupName) throws IOException;
+
+ /**
+ * Get the namespaces and tables which have this RegionServer group in descriptor.
+ * <p/>
+ * The difference between this method and {@link #listTablesInRSGroup(String)} is that, this
+ * method will not include the table which is actually in this RegionServr group but without the
+ * RegionServer group configuration in its {@link TableDescriptor}. For example, we have a group
+ * 'A', and we make namespace 'nsA' in this group, then all the tables under this namespace will
+ * in the group 'A', but this method will not return these tables but only the namespace 'nsA',
+ * while the {@link #listTablesInRSGroup(String)} will return all these tables.
+ * @param groupName the group name
+ * @throws IOException if a remote or network exception occurs
+ * @see #listTablesInRSGroup(String)
+ */
+ Pair<List<String>, List<TableName>> getConfiguredNamespacesAndTablesInRSGroup(String groupName)
Review comment:
The 'Configure' seems redundant to me given the suffix on method name is 'InRSGroup'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1165:
HBASE-22514 Move rsgroup feature into core of HBase
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1165: HBASE-22514 Move rsgroup feature into core of HBase
URL: https://github.com/apache/hbase/pull/1165#discussion_r378447342
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -382,7 +386,7 @@ public void run() {
private final LockManager lockManager = new LockManager(this);
- private LoadBalancer balancer;
+ private RSGroupBasedLoadBalancer balancer;
Review comment:
This balancer acts like old balancer when RSGroups is off? If so, just rename RSGroupBasedLB as LB?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services