You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jongwooo (via GitHub)" <gi...@apache.org> on 2023/09/27 15:24:14 UTC

[GitHub] [iceberg] jongwooo opened a new pull request, #8666: Build: Replace deprecated command with environment file

jongwooo opened a new pull request, #8666:
URL: https://github.com/apache/iceberg/pull/8666

   ## Description
   
   Closes #8665 
   
   Update `.github/workflows/jmh-benchmarks.yml` to use environment file instead of deprecated `set-output` command. 
   For more information, see: [https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)
   
   I found the workflow file that use `set-output` command through the following command:
   
   ```bash
   $ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'
   ```
   
   **AS-IS**
   
   ```yaml
   echo "::set-output name=matrix::[$matrix]"
   echo "::set-output name=foundlabel::$(echo "[$matrix]" | jq 'if . | length > 0 then true else false end')"
   ```
   
   **TO-BE**
   
   ```yaml
   echo "matrix=[$matrix]" >> $GITHUB_OUTPUT
   echo "foundlabel=$(echo "[$matrix]" | jq 'if . | length > 0 then true else false end')" >> $GITHUB_OUTPUT
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] Build: Replace deprecated command with environment file [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #8666:
URL: https://github.com/apache/iceberg/pull/8666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org