You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/04/15 05:07:38 UTC
Review Request 20356: Flume: add processes endpoint
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-5467
https://issues.apache.org/jira/browse/AMBARI-5467
Repository: ambari
Description
-------
* Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
* Also allow agents to write their own information there. These can be any name and change from service-to-service.
* Some flume script changes and fixes.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
ambari-server/src/main/resources/key_properties.json b3715cb
ambari-server/src/main/resources/properties.json a3f4fdd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
Diff: https://reviews.apache.org/r/20356/diff/
Testing
-------
OK
----------------------------------------------------------------------
Total run:529
Total errors:0
Total failures:0
OK
AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
log
Log not found
log
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:42.467s
[INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 20356: Flume: add processes endpoint
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/#review40377
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
<https://reviews.apache.org/r/20356/#comment73361>
Missing name for @param.
- Tom Beerbower
On April 15, 2014, 3:07 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20356/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 3:07 a.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5467
> https://issues.apache.org/jira/browse/AMBARI-5467
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
> * Also allow agents to write their own information there. These can be any name and change from service-to-service.
> * Some flume script changes and fixes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
> ambari-server/src/main/resources/key_properties.json b3715cb
> ambari-server/src/main/resources/properties.json a3f4fdd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
>
> Diff: https://reviews.apache.org/r/20356/diff/
>
>
> Testing
> -------
>
>
> OK
> ----------------------------------------------------------------------
> Total run:529
> Total errors:0
> Total failures:0
> OK
> AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
> log
> Log not found
> log
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:42.467s
> [INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20356: Flume: add processes endpoint
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/#review40376
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java
<https://reviews.apache.org/r/20356/#comment73360>
Not params of this method.
- Tom Beerbower
On April 15, 2014, 3:07 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20356/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 3:07 a.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5467
> https://issues.apache.org/jira/browse/AMBARI-5467
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
> * Also allow agents to write their own information there. These can be any name and change from service-to-service.
> * Some flume script changes and fixes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
> ambari-server/src/main/resources/key_properties.json b3715cb
> ambari-server/src/main/resources/properties.json a3f4fdd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
>
> Diff: https://reviews.apache.org/r/20356/diff/
>
>
> Testing
> -------
>
>
> OK
> ----------------------------------------------------------------------
> Total run:529
> Total errors:0
> Total failures:0
> OK
> AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
> log
> Log not found
> log
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:42.467s
> [INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20356: Flume: add processes endpoint
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/#review40460
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On April 15, 2014, 8:17 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20356/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 8:17 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5467
> https://issues.apache.org/jira/browse/AMBARI-5467
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
> * Also allow agents to write their own information there. These can be any name and change from service-to-service.
> * Some flume script changes and fixes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
> ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java fc7f7a2
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SchemaImpl.java 4227dbf
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Schema.java b2d7517
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
> ambari-server/src/main/resources/key_properties.json b3715cb
> ambari-server/src/main/resources/properties.json a3f4fdd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
>
> Diff: https://reviews.apache.org/r/20356/diff/
>
>
> Testing
> -------
>
>
> OK
> ----------------------------------------------------------------------
> Total run:529
> Total errors:0
> Total failures:0
> OK
> AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
> log
> Log not found
> log
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:42.467s
> [INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20356: Flume: add processes endpoint
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/
-----------------------------------------------------------
(Updated April 15, 2014, 4:17 p.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Changes
-------
Added a fix (thanks Tom!) that prevented proper fetching of a HostComponent resource
Bugs: AMBARI-5467
https://issues.apache.org/jira/browse/AMBARI-5467
Repository: ambari
Description
-------
* Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
* Also allow agents to write their own information there. These can be any name and change from service-to-service.
* Some flume script changes and fixes.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java fc7f7a2
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SchemaImpl.java 4227dbf
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Schema.java b2d7517
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
ambari-server/src/main/resources/key_properties.json b3715cb
ambari-server/src/main/resources/properties.json a3f4fdd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
Diff: https://reviews.apache.org/r/20356/diff/
Testing
-------
OK
----------------------------------------------------------------------
Total run:529
Total errors:0
Total failures:0
OK
AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
log
Log not found
log
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:42.467s
[INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 20356: Flume: add processes endpoint
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/#review40385
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On April 15, 2014, 12:08 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20356/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 12:08 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5467
> https://issues.apache.org/jira/browse/AMBARI-5467
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
> * Also allow agents to write their own information there. These can be any name and change from service-to-service.
> * Some flume script changes and fixes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
> ambari-server/src/main/resources/key_properties.json b3715cb
> ambari-server/src/main/resources/properties.json a3f4fdd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
>
> Diff: https://reviews.apache.org/r/20356/diff/
>
>
> Testing
> -------
>
>
> OK
> ----------------------------------------------------------------------
> Total run:529
> Total errors:0
> Total failures:0
> OK
> AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
> log
> Log not found
> log
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:42.467s
> [INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20356: Flume: add processes endpoint
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/
-----------------------------------------------------------
(Updated April 15, 2014, 8:08 a.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Changes
-------
Removed cluster and component size checks
Bugs: AMBARI-5467
https://issues.apache.org/jira/browse/AMBARI-5467
Repository: ambari
Description
-------
* Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
* Also allow agents to write their own information there. These can be any name and change from service-to-service.
* Some flume script changes and fixes.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
ambari-server/src/main/resources/key_properties.json b3715cb
ambari-server/src/main/resources/properties.json a3f4fdd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
Diff: https://reviews.apache.org/r/20356/diff/
Testing
-------
OK
----------------------------------------------------------------------
Total run:529
Total errors:0
Total failures:0
OK
AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
log
Log not found
log
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:42.467s
[INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 20356: Flume: add processes endpoint
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/
-----------------------------------------------------------
(Updated April 15, 2014, 7:22 a.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Changes
-------
Updated for javadoc fixes
Bugs: AMBARI-5467
https://issues.apache.org/jira/browse/AMBARI-5467
Repository: ambari
Description
-------
* Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
* Also allow agents to write their own information there. These can be any name and change from service-to-service.
* Some flume script changes and fixes.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
ambari-server/src/main/resources/key_properties.json b3715cb
ambari-server/src/main/resources/properties.json a3f4fdd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
Diff: https://reviews.apache.org/r/20356/diff/
Testing
-------
OK
----------------------------------------------------------------------
Total run:529
Total errors:0
Total failures:0
OK
AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
log
Log not found
log
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:42.467s
[INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 20356: Flume: add processes endpoint
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20356/#review40375
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java
<https://reviews.apache.org/r/20356/#comment73359>
Could we avoid this by internally making multiple requests and joining the results if needed?
- Tom Beerbower
On April 15, 2014, 3:07 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20356/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 3:07 a.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5467
> https://issues.apache.org/jira/browse/AMBARI-5467
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Add "processes" endpoint to HostComponents. This will minimally contain a name and status property. This patch seems big, but most changes are just a couple of lines.
> * Also allow agents to write their own information there. These can be any name and change from service-to-service.
> * Some flume script changes and fixes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java 31a7d3e
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 6a8373d
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentProcessResourceDefinition.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostComponentResourceDefinition.java a0e01f3
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java aeb46e1
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java c0f8297
> ambari-server/src/main/java/org/apache/ambari/server/controller/HostComponentProcessResponse.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java 880b13e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 56f9d49
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 82ee296
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java ba57a31
> ambari-server/src/main/resources/key_properties.json b3715cb
> ambari-server/src/main/resources/properties.json a3f4fdd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 431935b
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java acd401d
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 2cb51df
>
> Diff: https://reviews.apache.org/r/20356/diff/
>
>
> Testing
> -------
>
>
> OK
> ----------------------------------------------------------------------
> Total run:529
> Total errors:0
> Total failures:0
> OK
> AMBARI_CONF_DIR is not set, using default /etc/ambari-server/conf
> log
> Log not found
> log
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:42.467s
> [INFO] Finished at: Mon Apr 14 22:57:25 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>