You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by mt...@apache.org on 2010/02/16 09:41:41 UTC

svn commit: r910434 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

Author: mturk
Date: Tue Feb 16 08:41:41 2010
New Revision: 910434

URL: http://svn.apache.org/viewvc?rev=910434&view=rev
Log:
Add few code comments. No functional change

Modified:
    tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

Modified: tomcat/jk/trunk/native/iis/jk_isapi_plugin.c
URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/jk_isapi_plugin.c?rev=910434&r1=910433&r2=910434&view=diff
==============================================================================
--- tomcat/jk/trunk/native/iis/jk_isapi_plugin.c (original)
+++ tomcat/jk/trunk/native/iis/jk_isapi_plugin.c Tue Feb 16 08:41:41 2010
@@ -2393,6 +2393,9 @@
     int rc = JK_FALSE;
 
     if (!jk_open_file_logger(&logger, log_file, log_level)) {
+        /* TODO: Use System logging to notify the user that
+         *       we cannot open the configured log file.
+         */
         logger = NULL;
     }
     StringCbCopy(shm_name, MAX_PATH, SHM_DEF_NAME);
@@ -2529,11 +2532,14 @@
                     jk_log(logger, JK_LOG_WARNING,
                            "You can remove the shm_size attribute if you want to use the optimal size.");
                 }
-                if ((rv = jk_shm_open(shm_name, shm_config_size, logger)) != 0)
+                if ((rv = jk_shm_open(shm_name, shm_config_size, logger)) != 0) {
+                    /* TODO: Do not try to open the worker if we cannot creat
+                     *       the shared memory segment.
+                     */
                     jk_log(logger, JK_LOG_ERROR,
                            "Initializing shm:%s errno=%d. Load balancing workers will not function properly.",
                            jk_shm_name(), rv);
-
+                }
                 worker_env.uri_to_worker = uw_map;
                 worker_env.server_name = serverName;
                 worker_env.pool = NULL;



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org