You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/25 00:52:35 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #11006: Show logic SQL in execution process list Info column

sandynz opened a new pull request #11006:
URL: https://github.com/apache/shardingsphere/pull/11006


   Fixes #9568 part6.
   
   Changes proposed in this pull request:
   - Add `LogicSQL` in `ExecutionContext`, replace `SQLStatementContext`
   - Add `LogicSQL` in `ExecuteProcessReporter.report`, replace `SQLStatementContext`
   - Persist `LogicSQL.sql` to ZK
   - Show sql in `Info` column when executing "show processlist"
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #11006: Show logic SQL in execution process list Info column

Posted by GitBox <gi...@apache.org>.

sandynz commented on pull request #11006:
URL: https://github.com/apache/shardingsphere/pull/11006#issuecomment-868969800


   Manual test result:
   
   In one of MySQL client:
   ```
   mysql> alter table t_order drop column a;
   Query OK, 0 rows affected (50.54 sec)
   ```
   
   In another MySQL client:
   ```
   mysql> show processlist;
   +--------------------------------------+------+-----------------+-------------+---------+------+---------------+-----------------------------------+
   | Id                                   | User | Host            | db          | Command | Time | State         | Info                              |
   +--------------------------------------+------+-----------------+-------------+---------+------+---------------+-----------------------------------+
   | 21cedeb3-85f6-48d4-8e10-9c1da510f0b2 | root | 0:0:0:0:0:0:0:1 | sharding_db | Execute | 10   | Executing 0/4 | alter table t_order drop column a |
   +--------------------------------------+------+-----------------+-------------+---------+------+---------------+-----------------------------------+
   1 row in set (0.02 sec)
   
   mysql> show processlist;
   +--------------------------------------+------+-----------------+-------------+---------+------+---------------+-----------------------------------+
   | Id                                   | User | Host            | db          | Command | Time | State         | Info                              |
   +--------------------------------------+------+-----------------+-------------+---------+------+---------------+-----------------------------------+
   | 21cedeb3-85f6-48d4-8e10-9c1da510f0b2 | root | 0:0:0:0:0:0:0:1 | sharding_db | Execute | 27   | Executing 2/4 | alter table t_order drop column a |
   +--------------------------------------+------+-----------------+-------------+---------+------+---------------+-----------------------------------+
   1 row in set (0.02 sec)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #11006: Show logic SQL in execution process list Info column

Posted by GitBox <gi...@apache.org>.

sandynz commented on pull request #11006:
URL: https://github.com/apache/shardingsphere/pull/11006#issuecomment-868535545


   Hi @tristaZero , I'll try to find out classes need UT, and create issue for other participants.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #11006: Show logic SQL in execution process list Info column

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #11006:
URL: https://github.com/apache/shardingsphere/pull/11006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #11006: Show logic SQL in execution process list Info column

Posted by GitBox <gi...@apache.org>.

tristaZero commented on pull request #11006:
URL: https://github.com/apache/shardingsphere/pull/11006#issuecomment-869321176


   @sandynz Hey, looks nice!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #11006: Show logic SQL in execution process list Info column

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #11006:
URL: https://github.com/apache/shardingsphere/pull/11006#issuecomment-868122725


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11006](https://codecov.io/gh/apache/shardingsphere/pull/11006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa13fe8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/915d4572b7ee72a77891e8d130a1a5ca4b20ea04?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (915d457) will **increase** coverage by `0.11%`.
   > The diff coverage is `35.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11006/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11006      +/-   ##
   ============================================
   + Coverage     65.61%   65.72%   +0.11%     
     Complexity      713      713              
   ============================================
     Files          1810     1810              
     Lines         30815    30808       -7     
     Branches       5554     5550       -4     
   ============================================
   + Hits          20219    20249      +30     
   + Misses         9001     8961      -40     
   - Partials       1595     1598       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...text/process/GovernanceExecuteProcessReporter.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC9wcm9jZXNzL0dvdmVybmFuY2VFeGVjdXRlUHJvY2Vzc1JlcG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...e/infra/executor/sql/context/ExecutionContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9jb250ZXh0L0V4ZWN1dGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...a/executor/sql/execute/engine/raw/RawExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9leGVjdXRlL2VuZ2luZS9yYXcvUmF3RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...r/sql/federate/schema/row/FederateRowExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9zY2hlbWEvcm93L0ZlZGVyYXRlUm93RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/generator/FederateExecutionContextGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9zY2hlbWEvdGFibGUvZ2VuZXJhdG9yL0ZlZGVyYXRlRXhlY3V0aW9uQ29udGV4dEdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...fra/executor/sql/process/ExecuteProcessEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcm9jZXNzL0V4ZWN1dGVQcm9jZXNzRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...cutor/sql/process/model/ExecuteProcessContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcm9jZXNzL21vZGVsL0V4ZWN1dGVQcm9jZXNzQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../process/model/yaml/YamlExecuteProcessContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcm9jZXNzL21vZGVsL3lhbWwvWWFtbEV4ZWN1dGVQcm9jZXNzQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../proxy/backend/communication/ProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL1Byb3h5U1FMRXhlY3V0b3IuamF2YQ==) | `22.22% <0.00%> (ø)` | |
   | [...communication/jdbc/executor/ProxyJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0b3IvUHJveHlKREJDRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [30 more](https://codecov.io/gh/apache/shardingsphere/pull/11006/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11006?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11006?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [915d457...fa13fe8](https://codecov.io/gh/apache/shardingsphere/pull/11006?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org