[GitHub] [pulsar] 315157973 commented on a change in pull request #10348: Reader support seek from separate messageId/time

[GitBox <gi...@apache.org>]

315157973 commented on a change in pull request #10348:
URL: https://github.com/apache/pulsar/pull/10348#discussion_r628715834



##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Consumer.java
##########
@@ -600,26 +600,31 @@
     void seek(long timestamp) throws PulsarClientException;
 
     /**
-     * Reset the subscription associated with this consumer to a specific message id.
+     * Reset the subscription associated with this consumer to a specific message id or message publish time.
      * <p>
-     * The Function input is topic+partition.
+     * The Function input is topic+partition, and can only return timestamp or MessageId.
      * <p>
      * The return value is the seek position/timestamp of the current partition.
+     * Exception will be thrown if other types of objects are returned.
      * <p>
      * If returns null, the current partition will not do any processing.
+     * Exception in a partition may affect other partitions.
      * @param function
      * @throws PulsarClientException
      */
     void seek(Function<String, Object> function) throws PulsarClientException;
 
     /**
-     * Reset the subscription associated with this consumer to a specific message id asynchronously.
+     * Reset the subscription associated with this consumer to a specific message id

Review comment:
       Thanks, I will check other places




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org