You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wayneguow (via GitHub)" <gi...@apache.org> on 2024/08/07 10:42:06 UTC
[PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
wayneguow opened a new pull request, #47651:
URL: https://github.com/apache/spark/pull/47651
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to:
1. widening type promotion from int/long to decimal in `AvroDeserializer`. Supported as following(Avro Type -> Spark Type):
- Int -> Decimal ;
- Long -> Decimal ;
2. support custom decimal logic type for int
We already support long in #41409.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Similar to Parquet reader, we'd better to enable type promotion/widening for Avro deserializer.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, Users can use wider types more flexibly.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Pass GA and add some new test cases.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #47651:
URL: https://github.com/apache/spark/pull/47651#issuecomment-2290321357
@dongjoon-hyun Could you help to also review it when you have some time, cause that this PR contains some similar feature that you reviewed before(related PR: support custom decimal logic type for `long`). Thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47651:
URL: https://github.com/apache/spark/pull/47651#discussion_r1717355345
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -386,14 +386,46 @@ private[sql] class AvroDeserializer(
case (LONG, _: DayTimeIntervalType) => (updater, ordinal, value) =>
updater.setLong(ordinal, value.asInstanceOf[Long])
- case (LONG, _: DecimalType) => (updater, ordinal, value) =>
- val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
- updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case (INT, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
+ if (!isDecimalTypeMatched(INT, dt)) {
+ throw new IncompatibleSchemaException(incompatibleMsg)
+ }
+ (updater, ordinal, value) =>
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Int], dt.precision, dt.scale))
+ case _: CustomDecimal => (updater, ordinal, value) =>
+ val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Int], d.precision, d.scale))
+ case other => throw new IncompatibleSchemaException(errorPrefix +
+ s"Avro logical type $other cannot be converted to SQL type ${DecimalType.simpleString}.")
+ }
+
+ case (LONG, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
+ if (!isDecimalTypeMatched(LONG, dt)) {
+ throw new IncompatibleSchemaException(incompatibleMsg)
+ }
+ (updater, ordinal, value) =>
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], dt.precision, dt.scale))
+ case _: CustomDecimal => (updater, ordinal, value) =>
+ val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case other => throw new IncompatibleSchemaException(errorPrefix +
+ s"Avro logical type $other cannot be converted to SQL type ${DecimalType.simpleString}.")
+ }
case _ => throw new IncompatibleSchemaException(incompatibleMsg)
}
}
+ private def isDecimalTypeMatched(avroType: Schema.Type, dt: DecimalType): Boolean = {
+ avroType match {
+ case INT => dt.precision >= DecimalType.IntDecimal.precision && dt.scale == 0
Review Comment:
@cloud-fan What I want to discuss more about is here. Currently, I have relatively strict limitations on the precision and scale of `DecimalType`.
Do we need to consider allowing scale greater than 0 and precision that does not need to be completely greater than `IntDecimal` or `LongDecimal`? For example:
Is it reasonable to use `Decimal (7,2)` for the value `123456`
- Decimal(7, 2) => 123456.00
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #47651:
URL: https://github.com/apache/spark/pull/47651#discussion_r1717326267
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -386,14 +386,46 @@ private[sql] class AvroDeserializer(
case (LONG, _: DayTimeIntervalType) => (updater, ordinal, value) =>
updater.setLong(ordinal, value.asInstanceOf[Long])
- case (LONG, _: DecimalType) => (updater, ordinal, value) =>
- val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
- updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case (INT, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
Review Comment:
In addition to the INT support, seems we also added a few more checks. Can you say more about it in the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47651:
URL: https://github.com/apache/spark/pull/47651#issuecomment-2495717424
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47651:
URL: https://github.com/apache/spark/pull/47651#discussion_r1717771836
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -386,14 +386,46 @@ private[sql] class AvroDeserializer(
case (LONG, _: DayTimeIntervalType) => (updater, ordinal, value) =>
updater.setLong(ordinal, value.asInstanceOf[Long])
- case (LONG, _: DecimalType) => (updater, ordinal, value) =>
- val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
- updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case (INT, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
+ if (!isDecimalTypeMatched(INT, dt)) {
+ throw new IncompatibleSchemaException(incompatibleMsg)
+ }
+ (updater, ordinal, value) =>
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Int], dt.precision, dt.scale))
+ case _: CustomDecimal => (updater, ordinal, value) =>
+ val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Int], d.precision, d.scale))
+ case other => throw new IncompatibleSchemaException(errorPrefix +
+ s"Avro logical type $other cannot be converted to SQL type ${DecimalType.simpleString}.")
+ }
+
+ case (LONG, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
+ if (!isDecimalTypeMatched(LONG, dt)) {
+ throw new IncompatibleSchemaException(incompatibleMsg)
+ }
+ (updater, ordinal, value) =>
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], dt.precision, dt.scale))
+ case _: CustomDecimal => (updater, ordinal, value) =>
+ val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case other => throw new IncompatibleSchemaException(errorPrefix +
+ s"Avro logical type $other cannot be converted to SQL type ${DecimalType.simpleString}.")
+ }
case _ => throw new IncompatibleSchemaException(incompatibleMsg)
}
}
+ private def isDecimalTypeMatched(avroType: Schema.Type, dt: DecimalType): Boolean = {
+ avroType match {
+ case INT => dt.precision >= DecimalType.IntDecimal.precision && dt.scale == 0
Review Comment:
We didn't know the length of all value about int fields. However, this method is used when actually parsing data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #47651: [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer`
URL: https://github.com/apache/spark/pull/47651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47651:
URL: https://github.com/apache/spark/pull/47651#discussion_r1717343527
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -386,14 +386,46 @@ private[sql] class AvroDeserializer(
case (LONG, _: DayTimeIntervalType) => (updater, ordinal, value) =>
updater.setLong(ordinal, value.asInstanceOf[Long])
- case (LONG, _: DecimalType) => (updater, ordinal, value) =>
- val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
- updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case (INT, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
Review Comment:
In addition to supporting the use of widened DecimalType to read int and long; I also refer to the previously customized decimal logic type #41409 to read long, which is also supported when reading int.
If you think that these two parts are not suitable to be placed in one PR, I can seperate them apart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on code in PR #47651:
URL: https://github.com/apache/spark/pull/47651#discussion_r1717769551
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -386,14 +386,46 @@ private[sql] class AvroDeserializer(
case (LONG, _: DayTimeIntervalType) => (updater, ordinal, value) =>
updater.setLong(ordinal, value.asInstanceOf[Long])
- case (LONG, _: DecimalType) => (updater, ordinal, value) =>
- val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
- updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case (INT, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
Review Comment:
All of them are new feature supported.
1. For `int` field in Avro if we use `DecimalType` to read it:
- before, it throws a Exception;
- after, it can works;
And we also supported users to use `DecimalType` with `CustomDecimal` logic Type to read `int` fields.
2. For long field in Avro if we use DecimalType to read it:
- before, it throws a Exception with cause NPE;
- after, it can works;
And if users use `DecimalType` with `CustomDecimal` logic Type to read `long` fields, the exist feature still works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #47651:
URL: https://github.com/apache/spark/pull/47651#discussion_r1717726951
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -386,14 +386,46 @@ private[sql] class AvroDeserializer(
case (LONG, _: DayTimeIntervalType) => (updater, ordinal, value) =>
updater.setLong(ordinal, value.asInstanceOf[Long])
- case (LONG, _: DecimalType) => (updater, ordinal, value) =>
- val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
- updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case (INT, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
+ if (!isDecimalTypeMatched(INT, dt)) {
+ throw new IncompatibleSchemaException(incompatibleMsg)
+ }
+ (updater, ordinal, value) =>
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Int], dt.precision, dt.scale))
+ case _: CustomDecimal => (updater, ordinal, value) =>
+ val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Int], d.precision, d.scale))
+ case other => throw new IncompatibleSchemaException(errorPrefix +
+ s"Avro logical type $other cannot be converted to SQL type ${DecimalType.simpleString}.")
+ }
+
+ case (LONG, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
+ if (!isDecimalTypeMatched(LONG, dt)) {
+ throw new IncompatibleSchemaException(incompatibleMsg)
+ }
+ (updater, ordinal, value) =>
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], dt.precision, dt.scale))
+ case _: CustomDecimal => (updater, ordinal, value) =>
+ val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
+ updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case other => throw new IncompatibleSchemaException(errorPrefix +
+ s"Avro logical type $other cannot be converted to SQL type ${DecimalType.simpleString}.")
+ }
case _ => throw new IncompatibleSchemaException(incompatibleMsg)
}
}
+ private def isDecimalTypeMatched(avroType: Schema.Type, dt: DecimalType): Boolean = {
+ avroType match {
+ case INT => dt.precision >= DecimalType.IntDecimal.precision && dt.scale == 0
Review Comment:
How can we know the real value when reading the Avro metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #47651:
URL: https://github.com/apache/spark/pull/47651#discussion_r1717728181
##########
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala:
##########
@@ -386,14 +386,46 @@ private[sql] class AvroDeserializer(
case (LONG, _: DayTimeIntervalType) => (updater, ordinal, value) =>
updater.setLong(ordinal, value.asInstanceOf[Long])
- case (LONG, _: DecimalType) => (updater, ordinal, value) =>
- val d = avroType.getLogicalType.asInstanceOf[CustomDecimal]
- updater.setDecimal(ordinal, Decimal(value.asInstanceOf[Long], d.precision, d.scale))
+ case (INT, dt: DecimalType) => avroType.getLogicalType match {
+ case null =>
Review Comment:
Does it introduce any breaking change to end users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49140][SQL] Widening type promotion from int/long to decimal and support custom decimal logic type for int in `AvroDeserializer` [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #47651:
URL: https://github.com/apache/spark/pull/47651#issuecomment-2273466072
cc @dongjoon-hyun @cloud-fan thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org