[GitHub] [incubator-pekko-samples] mdedetrich commented on a diff in pull request #26: #243: Convert sharding-kafka to Pekko

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #26:
URL: https://github.com/apache/incubator-pekko-samples/pull/26#discussion_r1155836079


##########
pekko-sample-kafka-to-sharding-scala/build.sbt:
##########
@@ -0,0 +1,71 @@
+val pekkoVersion = "0.0.0+26628-198d0eb0-SNAPSHOT"

Review Comment:
   Can we change this version to `0.0.0+26623-85c2a469-SNAPSHOT`? For context the reason why this is being done is because a lot of the current Pekko modules are built against this version of Pekko



##########
pekko-sample-kafka-to-sharding-scala/processor/src/main/resources/logback.xml:
##########
@@ -3,13 +3,13 @@
 
     <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
         <encoder>
-            <pattern>[%date{ISO8601}] [%level] [%logger] [%thread] [%X{akkaSource}] - %msg%n</pattern>
+            <pattern>[%date{ISO8601}] [%level] [%logger] [%thread] [%X{pekkoSource}] - %msg%n</pattern>
         </encoder>
     </appender>
 
     <logger name="org.apache.kafka" level="WARN" />
 
-    <logger name="akka.cluster.sharding" level="DEBUG" />
+    <logger name="pekko.cluster.sharding" level="DEBUG" />

Review Comment:
   Shouldn't this be `org.apache.pekko` rather than just `pekko`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org