You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/01/27 13:49:08 UTC

[GitHub] [superset] kgabryje opened a new pull request, #22886: feat: Enable cross fitlers in WorldMap and Graph charts

kgabryje opened a new pull request, #22886:
URL: https://github.com/apache/superset/pull/22886

   
   ### SUMMARY
   This PR adds cross filtering functionality to Echarts Graph and World Map.
   Additionally, before user could only click on the edge of Graph chart to open a context menu for Drill By. This PR enables also clicking on nodes.
   
   Known issue - In graph chart, the selection after clicking gets cancelled after hovering on any other node or edge. This has yet to be fixed
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   https://user-images.githubusercontent.com/15073128/215102016-5e2ed689-fae5-4355-9f3c-a9c2a4069400.mov
   
   https://user-images.githubusercontent.com/15073128/215102065-9e5dfe3f-4148-491a-94c5-ea66dda942b3.mov
   
   
   ### TESTING INSTRUCTIONS
   1. Add Graph and World Map to a dashboard
   2. If dashboard has cross filtering enabled, clicking on a country (in World Map) or on a node (in Graph) should enable cross filtering.
   3. If dashboard has cross filtering disabled, clicking shouldn't do anything
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #22886: feat: Enable cross fitlers in WorldMap and Graph charts

Posted by codecov.
codecov[bot] commented on PR #22886:
URL: https://github.com/apache/superset/pull/22886#issuecomment-1408577134

   # [Codecov](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22886](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a8a029) into [master](https://codecov.io/gh/apache/superset/commit/8226110be8bea6f1b06ce02def7ea56df44e6b50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8226110) will **decrease** coverage by `0.06%`.
   > The diff coverage is `7.14%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #22886      +/-   ##
   ==========================================
   - Coverage   67.19%   67.14%   -0.06%     
   ==========================================
     Files        1870     1870              
     Lines       71746    71798      +52     
     Branches     7869     7876       +7     
   ==========================================
   - Hits        48209    48206       -3     
   - Misses      21519    21574      +55     
     Partials     2018     2018              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `53.69% <7.14%> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...gins/legacy-plugin-chart-world-map/src/WorldMap.js](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvV29ybGRNYXAuanM=) | `0.00% <0.00%> (ø)` | |
   | [...plugins/legacy-plugin-chart-world-map/src/index.js](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvaW5kZXguanM=) | `66.66% <ø> (ø)` | |
   | [...egacy-plugin-chart-world-map/src/transformProps.js](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXdvcmxkLW1hcC9zcmMvdHJhbnNmb3JtUHJvcHMuanM=) | `0.00% <0.00%> (ø)` | |
   | [...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvRWNoYXJ0c0dyYXBoLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [...nd/plugins/plugin-chart-echarts/src/Graph/index.ts](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvaW5kZXgudHM=) | `50.00% <ø> (ø)` | |
   | [...nd/plugins/plugin-chart-echarts/src/Graph/types.ts](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
   | [...s/plugin-chart-echarts/src/Graph/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvR3JhcGgvdHJhbnNmb3JtUHJvcHMudHM=) | `72.36% <100.00%> (ø)` | |
   | [...d/src/SqlLab/components/QueryAutoRefresh/index.tsx](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2gvaW5kZXgudHN4) | `58.62% <0.00%> (-12.22%)` | :arrow_down: |
   | [...mponents/useExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy91c2VFeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `60.67% <0.00%> (-3.19%)` | :arrow_down: |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `78.76% <0.00%> (-2.11%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/superset/pull/22886?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #22886: feat: Enable cross fitlers in WorldMap and Graph charts

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22886:
URL: https://github.com/apache/superset/pull/22886#issuecomment-1439717469

   @geido Ephemeral environment spinning up at http://34.220.105.103:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje merged pull request #22886: feat: Enable cross fitlers in WorldMap and Graph charts

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #22886:
URL: https://github.com/apache/superset/pull/22886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje commented on pull request #22886: feat: Enable cross fitlers in WorldMap and Graph charts

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #22886:
URL: https://github.com/apache/superset/pull/22886#issuecomment-1420725216

   > Error resolved with latest rebase! I found two other empty value edge cases – not sure if these need fixing or are expected:
   > 
   > 1. Empty value in graph chart doesn't trigger a cross filter:
   > 
   >  Screen.Recording.2023-02-03.at.12.36.27.PM.mov 
   > 
   > 2. World map behavior is different for empty countries when country is mapped to IOC code vs. country name:
   > 
   >  Screen.Recording.2023-02-03.at.12.36.44.PM.mov
   
   Thank you for testing!
   
   1. TBH I'd leave it as it is until we have an opposing product decision
   2. Thank you, fixed! I disabled clicking on those countries to match the behaviour of country names


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on pull request #22886: feat: Enable cross fitlers in WorldMap and Graph charts

Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #22886:
URL: https://github.com/apache/superset/pull/22886#issuecomment-1439714362

   /testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #22886: feat: Enable cross fitlers in WorldMap and Graph charts

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22886:
URL: https://github.com/apache/superset/pull/22886#issuecomment-1439799225

   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje commented on pull request #22886: feat: Enable cross fitlers in WorldMap and Graph charts

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #22886:
URL: https://github.com/apache/superset/pull/22886#issuecomment-1416011032

   > This is great! The one issue I ran into was that when I click a country with no values, I get an error:
   > 
   >  Screen.Recording.2023-02-01.at.5.21.28.PM.mov
   
   Oops, well spotted!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org