You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/13 20:07:58 UTC
[GitHub] flink pull request #4326: [FLINK-7178] [metrics] Do not create separate shad...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4326
[FLINK-7178] [metrics] Do not create separate shaded jars
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4326
----
commit 4b88f85d0ab0bdd65fc49fa7c27ba61a3309d2b4
Author: zentol <ch...@apache.org>
Date: 2017-07-13T20:06:56Z
[FLINK-7178] [metrics] Do not create separate shaded jars
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4326: [FLINK-7178] [metrics] Do not create separate shaded jars
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4326
@zentol What's the plan for merging this? (Asking because it's one of the remaining blockers for `1.3.2`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4326: [FLINK-7178] [metrics] Do not create separate shaded jars
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4326
Looks good.
I would suggest to add a description to the PR (be it only a copy of the JIRA text). Nice support for the reviewers to get context without manually navigating to JIRA to learn about the bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4326: [FLINK-7178] [metrics] Do not create separate shaded jars
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4326
@aljoscha The fix is not quite correct since I didn't update the flink-dist assembly files. Just pushed a fix for that though. I can merge it later today. (once my local travis passed for it)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4326: [FLINK-7178] [metrics] Do not create separate shad...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4326: [FLINK-7178] [metrics] Do not create separate shad...
Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/4326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4326: [FLINK-7178] [metrics] Do not create separate shad...
Posted by zentol <gi...@git.apache.org>.
GitHub user zentol reopened a pull request:
https://github.com/apache/flink/pull/4326
[FLINK-7178] [metrics] Do not create separate shaded jars
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4326.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4326
----
commit 4b88f85d0ab0bdd65fc49fa7c27ba61a3309d2b4
Author: zentol <ch...@apache.org>
Date: 2017-07-13T20:06:56Z
[FLINK-7178] [metrics] Do not create separate shaded jars
commit 7f3b6e167089d616f190f380e332ea27f3f98efb
Author: zentol <ch...@apache.org>
Date: 2017-07-17T14:08:54Z
fix assemblies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---