You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by hc...@apache.org on 2014/11/06 19:33:17 UTC
thrift git commit: THRIFT-2801: cpp - compilation warnings removed
from test suite
Repository: thrift
Updated Branches:
refs/heads/master cc092b37c -> b3f5ffc42
THRIFT-2801: cpp - compilation warnings removed from test suite
Client: C++
Patch: Konrad Grochowski
Unused parameters mostly
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/b3f5ffc4
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/b3f5ffc4
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/b3f5ffc4
Branch: refs/heads/master
Commit: b3f5ffc42d4c52e4a76ff429411164d27fb65b22
Parents: cc092b3
Author: Konrad Grochowski <hc...@apache.org>
Authored: Thu Nov 6 19:32:59 2014 +0100
Committer: Konrad Grochowski <hc...@apache.org>
Committed: Thu Nov 6 19:32:59 2014 +0100
----------------------------------------------------------------------
lib/cpp/test/OpenSSLManualInitTest.cpp | 2 ++
lib/cpp/test/TransportTest.cpp | 2 ++
lib/cpp/test/ZlibTest.cpp | 2 ++
lib/cpp/test/processor/Handlers.h | 5 +++++
lib/cpp/test/processor/ProcessorTest.cpp | 7 +++----
lib/cpp/test/processor/ServerThread.h | 2 +-
6 files changed, 15 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/thrift/blob/b3f5ffc4/lib/cpp/test/OpenSSLManualInitTest.cpp
----------------------------------------------------------------------
diff --git a/lib/cpp/test/OpenSSLManualInitTest.cpp b/lib/cpp/test/OpenSSLManualInitTest.cpp
index c403b18..fbecbc3 100644
--- a/lib/cpp/test/OpenSSLManualInitTest.cpp
+++ b/lib/cpp/test/OpenSSLManualInitTest.cpp
@@ -67,6 +67,8 @@ void test_openssl_availability() {
}
boost::unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) {
+ THRIFT_UNUSED_VARIABLE(argc);
+ THRIFT_UNUSED_VARIABLE(argv);
boost::unit_test::test_suite* suite =
&boost::unit_test::framework::master_test_suite();
suite->p_name.value = "OpenSSLManualInit";
http://git-wip-us.apache.org/repos/asf/thrift/blob/b3f5ffc4/lib/cpp/test/TransportTest.cpp
----------------------------------------------------------------------
diff --git a/lib/cpp/test/TransportTest.cpp b/lib/cpp/test/TransportTest.cpp
index 78c2764..c1cb976 100755
--- a/lib/cpp/test/TransportTest.cpp
+++ b/lib/cpp/test/TransportTest.cpp
@@ -1046,6 +1046,8 @@ struct global_fixture {
BOOST_GLOBAL_FIXTURE(global_fixture)
boost::unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) {
+ THRIFT_UNUSED_VARIABLE(argc);
+ THRIFT_UNUSED_VARIABLE(argv);
struct timeval tv;
THRIFT_GETTIMEOFDAY(&tv, NULL);
int seed = tv.tv_sec ^ tv.tv_usec;
http://git-wip-us.apache.org/repos/asf/thrift/blob/b3f5ffc4/lib/cpp/test/ZlibTest.cpp
----------------------------------------------------------------------
diff --git a/lib/cpp/test/ZlibTest.cpp b/lib/cpp/test/ZlibTest.cpp
index 1e8b646..49c5514 100644
--- a/lib/cpp/test/ZlibTest.cpp
+++ b/lib/cpp/test/ZlibTest.cpp
@@ -386,6 +386,8 @@ void print_usage(FILE* f, const char* argv0) {
}
boost::unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) {
+ THRIFT_UNUSED_VARIABLE(argc);
+ THRIFT_UNUSED_VARIABLE(argv);
uint32_t seed = static_cast<uint32_t>(time(NULL));
printf("seed: %" PRIu32 "\n", seed);
rng.seed(seed);
http://git-wip-us.apache.org/repos/asf/thrift/blob/b3f5ffc4/lib/cpp/test/processor/Handlers.h
----------------------------------------------------------------------
diff --git a/lib/cpp/test/processor/Handlers.h b/lib/cpp/test/processor/Handlers.h
index 2be262a..75f4349 100644
--- a/lib/cpp/test/processor/Handlers.h
+++ b/lib/cpp/test/processor/Handlers.h
@@ -244,6 +244,9 @@ class ServerEventHandler : public server::TServerEventHandler {
#if 0
ConnContext* context = reinterpret_cast<ConnContext*>(serverContext);
log_->append(EventLog::ET_PROCESS, context->id, 0);
+#else
+ THRIFT_UNUSED_VARIABLE(serverContext);
+ THRIFT_UNUSED_VARIABLE(transport);
#endif
}
@@ -285,6 +288,7 @@ class ProcessorEventHandler : public TProcessorEventHandler {
}
void postRead(void* ctx, const char* fnName, uint32_t bytes) {
+ THRIFT_UNUSED_VARIABLE(bytes);
CallContext* context = reinterpret_cast<CallContext*>(ctx);
checkName(context, fnName);
log_->append(EventLog::ET_POST_READ, context->connContext->id, context->id,
@@ -299,6 +303,7 @@ class ProcessorEventHandler : public TProcessorEventHandler {
}
void postWrite(void* ctx, const char* fnName, uint32_t bytes) {
+ THRIFT_UNUSED_VARIABLE(bytes);
CallContext* context = reinterpret_cast<CallContext*>(ctx);
checkName(context, fnName);
log_->append(EventLog::ET_POST_WRITE, context->connContext->id,
http://git-wip-us.apache.org/repos/asf/thrift/blob/b3f5ffc4/lib/cpp/test/processor/ProcessorTest.cpp
----------------------------------------------------------------------
diff --git a/lib/cpp/test/processor/ProcessorTest.cpp b/lib/cpp/test/processor/ProcessorTest.cpp
index 0283d20..8b806b4 100644
--- a/lib/cpp/test/processor/ProcessorTest.cpp
+++ b/lib/cpp/test/processor/ProcessorTest.cpp
@@ -932,10 +932,9 @@ DEFINE_NOFRAME_TESTS(TSimpleServer, Untemplated)
// TODO: We should test TEventServer in the future.
// For now, it is known not to work correctly with TProcessorEventHandler.
-
unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) {
- unit_test::framework::master_test_suite().p_name.value =
- "ProcessorTest";
-
+ THRIFT_UNUSED_VARIABLE(argc);
+ THRIFT_UNUSED_VARIABLE(argv);
+ unit_test::framework::master_test_suite().p_name.value = "ProcessorTest";
return NULL;
}
http://git-wip-us.apache.org/repos/asf/thrift/blob/b3f5ffc4/lib/cpp/test/processor/ServerThread.h
----------------------------------------------------------------------
diff --git a/lib/cpp/test/processor/ServerThread.h b/lib/cpp/test/processor/ServerThread.h
index 0dd5127..f7fa0d5 100644
--- a/lib/cpp/test/processor/ServerThread.h
+++ b/lib/cpp/test/processor/ServerThread.h
@@ -61,7 +61,7 @@ class ServerState {
* Subclasses may override this method if they wish to record the final
* port that was used for the server.
*/
- virtual void bindSuccessful(uint16_t port) {
+ virtual void bindSuccessful(uint16_t /*port*/) {
}
};