You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Nathan Bubna (JIRA)" <ve...@apache.org> on 2006/11/10 19:41:38 UTC
[jira] Commented: (VELTOOLS-67) Patch implementing path-scoped
tools
[ http://issues.apache.org/jira/browse/VELTOOLS-67?page=comments#action_12448819 ]
Nathan Bubna commented on VELTOOLS-67:
--------------------------------------
Ok, here's some pushback...
i'm not sure i like putting the path restrictions down as a scope.
a) it causes the value into ServletToolInfo.setScope() to not match getScope()
b) what if you want to restrict a session/application oriented tool to certain paths?
what do you think about making the path a totally separate property of ServletToolInfo? i know that makes things more complicated, especially in ServletToolboxManager.getToolbox() if we want to path-restrict session/application tools. Maybe to start things off we could have the path restriction as a separate property and add a fourth "request-path" scope option. Then we don't get a set/getScope mismatch and still limit path restriction to request scope (simplifying getToolbox()) but leave open the possibility of allowing session or application tools to be path-restricted.
thoughts anyone (esp Claude)?
> Patch implementing path-scoped tools
> ------------------------------------
>
> Key: VELTOOLS-67
> URL: http://issues.apache.org/jira/browse/VELTOOLS-67
> Project: VelocityTools
> Issue Type: New Feature
> Components: VelocityView
> Affects Versions: 1.3
> Environment: all
> Reporter: Claude Brisson
> Assigned To: Nathan Bubna
> Priority: Minor
> Attachments: path-scopes.patch
>
>
> This patch adds two new scopes:
> <scope>/some_path/*</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests having an URI that begins with /some_path/.
> <scope>/some_pathname</scope> is a subset of the request scope restricting the instantiation of tools to servlet requests whose URI matches exactly /some_pathname
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org