You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/16 09:01:09 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #4784: Python: Set Python 3.8 as minimal version
Fokko opened a new pull request, #4784:
URL: https://github.com/apache/iceberg/pull/4784
Python 3.8 has some nice features, like:
- The Walrus operator := https://realpython.com/python-walrus-operator/
- Ability to cache properties: @cached_property https://docs.python.org/3/library/functools.html#functools.cached_property
- (this is a non-exhaustist list that we can append to over time)
3.7 has still support for a bit over a year: https://endoflife.date/python
I've added 3.10 to the CI as well. Not sure if we can deprecate 3.7 just yet since it is still being used a lot:
The Python version that downloads packages from PyPI
Pulled this from BigQuery: https://console.cloud.google.com/bigquery?p=bigquery-public-data&d=pypi&page=dataset
That being said, upgrading from 3.7 to 3.8 should be quite easy nowadays with minimal breaking changes on the Python side, and just swapping out a base docker image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] samredai commented on pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
samredai commented on PR #4784:
URL: https://github.com/apache/iceberg/pull/4784#issuecomment-1129292346
I think this is ok. Security support will be dropped for 3.7 within a year which means in a few months, everyone will begin scrambling to get everything off of 3.7 anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4784:
URL: https://github.com/apache/iceberg/pull/4784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #4784:
URL: https://github.com/apache/iceberg/pull/4784#issuecomment-1129920145
@samredai I agree, and once all the Debian/Ubuntu-based images start shipping 3.8, I'll go very fast :) Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #4784:
URL: https://github.com/apache/iceberg/pull/4784#issuecomment-1129919526
Thanks @danielcweeks for noticing. I've just updated the PR and removed all the Python 3.7 related stuff (including singledispatch). Less is more 💪🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #4784:
URL: https://github.com/apache/iceberg/pull/4784#issuecomment-1130270966
Also, Dask requires 3.8+ so we're in good company.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4784:
URL: https://github.com/apache/iceberg/pull/4784#issuecomment-1130270256
Sounds like there's consensus around moving to 3.8. I'll merge this. Thanks, @Fokko!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4784:
URL: https://github.com/apache/iceberg/pull/4784#issuecomment-1129087293
I'm fine with this change, since I think we still support 3.7 for the legacy API. It really comes down to what people in the community are using, but since this is the new Python library I don't think there are that many people using it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks commented on pull request #4784: Python: Set Python 3.8 as minimal version
Posted by GitBox <gi...@apache.org>.
danielcweeks commented on PR #4784:
URL: https://github.com/apache/iceberg/pull/4784#issuecomment-1129280496
I just merged #4767 which had a little logic around 3.7, which you might want to remove as part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org