You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/04/18 17:24:00 UTC
[jira] [Commented] (HBASE-20443) Add an HBase antipattern check for
reintroducing commons-collections 3
[ https://issues.apache.org/jira/browse/HBASE-20443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442896#comment-16442896 ]
Hadoop QA commented on HBASE-20443:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 6s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-checkstyle {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 20s{color} | {color:red} hbase-common: The patch generated 1 new + 85 unchanged - 0 fixed = 86 total (was 85) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 25s{color} | {color:red} hbase-client: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 8s{color} | {color:red} hbase-replication: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 3s{color} | {color:red} hbase-server: The patch generated 6 new + 333 unchanged - 1 fixed = 339 total (was 334) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} hbase-backup: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 9s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 13m 7s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-checkstyle {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s{color} | {color:green} hbase-checkstyle in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 18s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 52s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}110m 21s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m 3s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}183m 42s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20443 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12919629/HBASE-20443.master.001.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux f40f12320ca7 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / f4f2b68238 |
| maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12536/artifact/patchprocess/diff-checkstyle-hbase-common.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12536/artifact/patchprocess/diff-checkstyle-hbase-client.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12536/artifact/patchprocess/diff-checkstyle-hbase-replication.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12536/artifact/patchprocess/diff-checkstyle-hbase-server.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/12536/artifact/patchprocess/diff-checkstyle-hbase-backup.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12536/testReport/ |
| Max. process+thread count | 4730 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle hbase-common hbase-client hbase-replication hbase-server hbase-backup U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12536/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add an HBase antipattern check for reintroducing commons-collections 3
> ----------------------------------------------------------------------
>
> Key: HBASE-20443
> URL: https://issues.apache.org/jira/browse/HBASE-20443
> Project: HBase
> Issue Type: Task
> Components: dependencies, test
> Reporter: Sean Busbey
> Assignee: Balazs Meszaros
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20443.master.001.patch
>
>
> we upgraded to commons-collections 4 in HBASE-18704 and then to an internal-only hbase-thirdparty version in HBASE-20223, but we've regressed:
> {code}
> $ git grep "import org.apache.commons.collections"
> hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java:import org.apache.commons.collections.MapUtils;
> hbase-client/src/main/java/org/apache/hadoop/hbase/client/RowMutations.java:import org.apache.commons.collections.CollectionUtils;
> hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:import org.apache.commons.collections.CollectionUtils;
> hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java:import org.apache.commons.collections.CollectionUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:import org.apache.commons.collections.CollectionUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:import org.apache.commons.collections.CollectionUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:import org.apache.commons.collections.CollectionUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java:import org.apache.commons.collections.CollectionUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import org.apache.commons.collections.CollectionUtils;
> hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java:import org.apache.commons.collections.MapUtils;
> {code}
> we should add the same kind of check as we do for e.g. hadoop annotations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)