You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2018/11/30 14:57:59 UTC

[GitHub] tobias-istvan opened a new pull request #50: [AMBARI-24975] Log Search UI: if there are multiple clusters - selecting one of it does not do anything

tobias-istvan opened a new pull request #50: [AMBARI-24975] Log Search UI: if there are multiple clusters - selecting one of it does not do anything
URL: https://github.com/apache/ambari-logsearch/pull/50
 
 
   # What changes were proposed in this pull request?
   
   I removed the bi-direction data binding in dropdown list item, so that the change can be detected in the parent component. Also I changed the way of the selection change in `selectAll` and the `unSelectAll` methods in order to the parent component has chance to detect change(s). 
   
   ## How was this patch tested?
   
   It was tested manually (checking all the displayed dropdowns selection change) and by unit tests:
   ```
   PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 292 of 292 SUCCESS (19.635 secs / 19.439 secs)
   ```
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services