[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4145: Add TO API Routing Blacklist via cdn.conf

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #4145: Add TO API Routing Blacklist via cdn.conf
URL: https://github.com/apache/trafficcontrol/pull/4145#discussion_r350327294
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/config/config.go
 ##########
 @@ -108,6 +109,12 @@ type ConfigTrafficOpsGolang struct {
 	CRConfigEmulateOldPath bool `json:"crconfig_emulate_old_path"`
 }
 
+// RoutingBlacklist contains the list of route IDs that will be handled by TO-Perl and a list of route IDs that are disabled.
+type RoutingBlacklist struct {
+	PerlRoutes     []int `json:"perl_routes"`
+	DisabledRoutes []int `json:"disabled_routes"`
+}
 
 Review comment:
   Changing these "route IDs" is also going to break any Production blacklist config, so they need to be immutable. That seems to be suggested on the mailing list, but I don't see it anywhere here.
   
   Would you mind adding something to that effect, both in the TO Dev Docs, and as a comment in the file here? 
   
   Otherwise, someone might see the mostly-ordered numbers here, and think they should be ordered, and change them when adding a new route.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services