You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Aman Sinha (Code Review)" <ge...@cloudera.org> on 2020/06/30 17:13:12 UTC
[Impala-ASF-CR] IMPALA-9898: Plan generation and execution for grouping sets
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16115
to look at the new patch set (#3).
Change subject: IMPALA-9898: Plan generation and execution for grouping sets
......................................................................
IMPALA-9898: Plan generation and execution for grouping sets
This patch enhances the MultiAggregateInfo to handle grouping sets
and rollup (which is converted to grouping sets). This patch does
not itself do parsing/validation of grouping sets syntax but rather
provides the following supporting functionality:
- A separate analyze method that accepts aggregation classes and
aggregation info that have been created separately.
- A modified Transpose phase that uses combination of aggif(),
valid_tid() functions and CASE exprs to choose exactly which
slots from the underlying aggregate classes need to be output
based on the tuple id.
- Modified materialization step where all aggregate slots and
grouping slots are materialized in case of grouping sets.
- Creates grouping_id value for grouping sets. The grouping_id
function in SQL describes which expression is grouped-by in a
particular row of a query with grouping sets.
Testing:
This patch is not individually testable but will be tested
as part of the overall grouping set support.
Change-Id: Id474c5373860b0d8014ee9c844a3fb90092be968
---
M fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java
1 file changed, 266 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/16115/3
--
To view, visit http://gerrit.cloudera.org:8080/16115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id474c5373860b0d8014ee9c844a3fb90092be968
Gerrit-Change-Number: 16115
Gerrit-PatchSet: 3
Gerrit-Owner: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>