You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Richard Zowalla (Jira)" <ji...@apache.org> on 2021/05/05 12:02:00 UTC
[jira] [Commented] (TOMEE-3739) Fix JAX-RS landscape / regressions
introduced during TCK Work
[ https://issues.apache.org/jira/browse/TOMEE-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339621#comment-17339621 ]
Richard Zowalla commented on TOMEE-3739:
----------------------------------------
Copying my comments from slack to give some context:
* (1) I think, that we are missing a not NULL check in [https://github.com/apache/tomee/blob/861e65ba7fe11f28c52a020f26bfe368a294f665/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java#L832] Adding "original != null" before the recursive call will solve a lot of test failures for this module.
* (2) We are missing the Json providers from [https://github.com/apache/tomee/commit/91c6613fcc7114807b7f76f5ac16b51a856d9a8e] (seems we do not add them back in CXF).
* (3) Same as (1) - I think we are missing a not NULL check in [https://github.com/apache/tomee/blob/861e65ba7fe11f28c52a020f26bfe368a294f665/serv[…]in/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java|https://github.com/apache/tomee/blob/861e65ba7fe11f28c52a020f26bfe368a294f665/server/openejb-cxf-rs/src/main/java/org/apache/openejb/server/cxf/rs/CxfRsHttpListener.java#L1165] for "application"
* (4) If (1) - (3) are "applied" locally, the only failing thing is "AppPropertiesPropagationTest" for which I have no idea.
> Fix JAX-RS landscape / regressions introduced during TCK Work
> -------------------------------------------------------------
>
> Key: TOMEE-3739
> URL: https://issues.apache.org/jira/browse/TOMEE-3739
> Project: TomEE
> Issue Type: Bug
> Affects Versions: 8.0.7
> Reporter: Richard Zowalla
> Priority: Critical
>
> We have some regressions in the JAX-RS landscape
> {code:java}
> 03-May-2021 15:54:29.502 SCHWERWIEGEND [main] org.apache.openejb.observer.ObserverManager$MethodInvocation.invoke error invoking org.apache.tomee.webservices.TomeeJaxRsService@5f354bcf
> java.lang.NullPointerException
> at org.apache.cxf.jaxrs.model.ProviderInfo.<init>(ProviderInfo.java:74)
> at org.apache.cxf.jaxrs.model.ProviderInfo.<init>(ProviderInfo.java:54)
> at org.apache.cxf.jaxrs.model.ApplicationInfo.<init>(ApplicationInfo.java:38)
> at org.apache.cxf.jaxrs.model.ApplicationInfo.<init>(ApplicationInfo.java:33)
> at org.apache.openejb.server.cxf.rs.CxfRsHttpListener.injectApplication(CxfRsHttpListener.java:837)
> at org.apache.openejb.server.cxf.rs.CxfRsHttpListener.injectApplication(CxfRsHttpListener.java:832)
> at org.apache.openejb.server.cxf.rs.CxfRsHttpListener.deployApplication(CxfRsHttpListener.java:732)
> at org.apache.openejb.server.rest.RESTService.deployApplication(RESTService.java:545)
> at org.apache.openejb.server.rest.RESTService.afterApplicationCreated(RESTService.java:305)
> at org.apache.tomee.webservices.TomeeJaxRsService.afterApplicationCreated(TomeeJaxRsService.java:53)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at org.apache.openejb.observer.ObserverManager$MethodInvocation.invoke(ObserverManager.java:402)
> at org.apache.openejb.observer.ObserverManager$InvocationList.invoke(ObserverManager.java:519)
> at org.apache.openejb.observer.ObserverManager$BeforeAndAfterInvocationSet.invoke(ObserverManager.java:499)
> at org.apache.openejb.observer.ObserverManager.doFire(ObserverManager.java:111)
> at org.apache.openejb.observer.ObserverManager.fireEvent(ObserverManager.java:100)
> at org.apache.openejb.loader.SystemInstance.fireEvent(SystemInstance.java:147)
> at org.apache.tomee.catalina.TomcatWebAppBuilder.afterStart(TomcatWebAppBuilder.java:1817)
> at org.apache.tomee.catalina.GlobalListenerSupport.lifecycleEvent(GlobalListenerSupport.java:117)
> at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
> at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:423)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:193)
> at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1384)
> at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1374)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
> at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
> at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:909)
> at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:843)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1384)
> at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1374)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
> at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
> at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:909)
> at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> at org.apache.catalina.core.StandardService.startInternal(StandardService.java:433)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:930)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
> at org.apache.catalina.startup.Catalina.start(Catalina.java:772)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:342)
> at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:473)
> {code}
> {code:java}
> 03-May-2021 15:57:11.190 INFORMATION [http-nio-8787-exec-1] org.apache.openejb.server.cxf.rs.CxfRsHttpListener.isCXFResource No JAX-RS service
> {code}
> This is basically reproducable via the unit tests in the *openejb-cxf-rs* module.
>
> *References*
> [http://mail-archives.apache.org/mod_mbox/tomee-dev/202105.mbox/%3Ccf10c954871f8dbb69f74f28a74b450c0126e63c.camel%40hs-heilbronn.de%3E]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)