You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by marcaurele <gi...@git.apache.org> on 2017/02/06 13:09:53 UTC

[GitHub] cloudstack pull request #1934: [CLOUDSTACK-9772] Template: perform a HEAD re...

GitHub user marcaurele opened a pull request:

    https://github.com/apache/cloudstack/pull/1934

    [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

    Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/exoscale/cloudstack fix/CLOUDSTACK-9772

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1934
    
----
commit 46fb454f4deb6c36f52a6e943b1f23c45508ab04
Author: Marc-Aur�le Brothier <m...@brothier.org>
Date:   2017-02-06T12:51:14Z

    Template: perform a HEAD request to check file size from a URL
    
    Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by borisstoyanov <gi...@git.apache.org>.

Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    @blueorangutan test 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by remibergsma <gi...@git.apache.org>.

Github user remibergsma commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    What about signed S3 urls that people may supply? If you want to register a template and have it download from a S3 bucket, you need to specify a signed url to provide the authentication. But that signature is valid for either GET or HEAD requests, not both. 
    
    When you use S3 as secondary storage, you automatically get a GET pre-signed url from CloudStack that you cannot use to register it as a new template. Something to think about..
    
    See: http://stackoverflow.com/questions/15717230/pre-signing-amazon-s3-urls-for-both-head-and-get-verbs 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by borisstoyanov <gi...@git.apache.org>.

Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    OK @marcaurele, if you're 100% sure it works as expected it could be that we need to redesign the test itself, I guess it needs deeper investigation of the failure itself. 
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by borisstoyanov <gi...@git.apache.org>.

Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    @marcaurele there are some marvin tests in extract and delete template, could you please have a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by blueorangutan <gi...@git.apache.org>.

Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by blueorangutan <gi...@git.apache.org>.

Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by marcaurele <gi...@git.apache.org>.

Github user marcaurele commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    @remibergsma Good point, I was aware of that difference, which I think doesn't help to make systems reliable.
    Another improvement would be to remove this function and refactor the code to read sizes from the template objects in the DB or on the GET requests when downloading them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by borisstoyanov <gi...@git.apache.org>.

Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

Posted by blueorangutan <gi...@git.apache.org>.

Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1934
  
    <b>Trillian test result (tid-805)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 30524 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1934-t805-kvm-centos7.zip
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
    Intermitten failure detected: /marvin/tests/smoke/test_templates.py
    Test completed. 47 look ok, 2 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_04_rvpc_privategw_static_routes | `Failure` | 345.56 | test_privategw_acl.py
    test_04_extract_template | `Error` | 5.09 | test_templates.py
    test_03_delete_template | `Error` | 5.09 | test_templates.py
    test_01_vpc_site2site_vpn | Success | 160.59 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 66.24 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 251.04 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 277.10 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 530.30 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 522.63 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1418.66 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 543.48 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 750.07 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1286.15 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 156.47 | test_volumes.py
    test_08_resize_volume | Success | 156.38 | test_volumes.py
    test_07_resize_fail | Success | 161.45 | test_volumes.py
    test_06_download_detached_volume | Success | 156.43 | test_volumes.py
    test_05_detach_volume | Success | 155.74 | test_volumes.py
    test_04_delete_attached_volume | Success | 151.25 | test_volumes.py
    test_03_download_attached_volume | Success | 156.33 | test_volumes.py
    test_02_attach_volume | Success | 124.15 | test_volumes.py
    test_01_create_volume | Success | 716.59 | test_volumes.py
    test_03_delete_vm_snapshots | Success | 275.22 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Success | 95.77 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Success | 163.77 | test_vm_snapshots.py
    test_deploy_vm_multiple | Success | 267.73 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.65 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 41.02 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.86 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 125.83 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 40.34 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 40.55 | test_templates.py
    test_08_list_system_templates | Success | 0.05 | test_templates.py
    test_07_list_public_templates | Success | 0.04 | test_templates.py
    test_05_template_permissions | Success | 0.05 | test_templates.py
    test_02_edit_template | Success | 90.11 | test_templates.py
    test_01_create_template | Success | 45.45 | test_templates.py
    test_10_destroy_cpvm | Success | 136.60 | test_ssvm.py
    test_09_destroy_ssvm | Success | 168.61 | test_ssvm.py
    test_08_reboot_cpvm | Success | 101.50 | test_ssvm.py
    test_07_reboot_ssvm | Success | 133.49 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.67 | test_ssvm.py
    test_05_stop_ssvm | Success | 133.83 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.22 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.45 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 11.12 | test_snapshots.py
    test_04_change_offering_small | Success | 239.69 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.13 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
    test_09_reboot_router | Success | 35.30 | test_routers.py
    test_08_start_router | Success | 30.30 | test_routers.py
    test_07_stop_router | Success | 10.19 | test_routers.py
    test_06_router_advanced | Success | 0.06 | test_routers.py
    test_05_router_basic | Success | 0.04 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.68 | test_routers.py
    test_03_restart_network_cleanup | Success | 55.50 | test_routers.py
    test_02_router_internal_adv | Success | 1.05 | test_routers.py
    test_01_router_internal_basic | Success | 0.58 | test_routers.py
    test_router_dns_guestipquery | Success | 76.77 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.07 | test_router_dns.py
    test_router_dhcphosts | Success | 278.19 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.76 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.09 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 130.94 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.04 | test_regions.py
    test_create_pvlan_network | Success | 5.20 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.43 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 475.44 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 370.11 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 87.12 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.76 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.19 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.47 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 89.37 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.13 | test_over_provisioning.py
    test_oobm_zchange_password | Success | 30.66 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.31 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.23 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.33 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.32 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.35 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.33 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.33 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 93.08 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.18 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.25 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.11 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.08 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 23.43 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.32 | test_non_contigiousvlan.py
    test_01_nic | Success | 429.25 | test_nic.py
    test_releaseIP | Success | 242.83 | test_network.py
    test_reboot_router | Success | 408.41 | test_network.py
    test_public_ip_user_account | Success | 10.25 | test_network.py
    test_public_ip_admin_account | Success | 40.29 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.93 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.71 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.17 | test_network.py
    test_delete_account | Success | 272.76 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.66 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.72 | test_network.py
    test_nic_secondaryip_add_remove | Success | 202.51 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 19.14 | test_login.py
    test_assign_and_removal_lb | Success | 133.62 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 187.39 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 228.11 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.06 | test_iso.py
    test_05_iso_permissions | Success | 0.06 | test_iso.py
    test_04_extract_Iso | Success | 5.13 | test_iso.py
    test_03_delete_iso | Success | 95.15 | test_iso.py
    test_02_edit_iso | Success | 0.06 | test_iso.py
    test_01_create_iso | Success | 21.00 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 193.03 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 147.94 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 525.84 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 430.96 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.27 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 6.17 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 6.01 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.85 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.88 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 6.00 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 5.89 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.97 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.89 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 10.92 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.88 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.86 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 8.03 | test_dynamicroles.py
    test_role_account_acls | Success | 8.21 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.98 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.10 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 20.60 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 20.59 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 65.70 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 10.42 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 70.86 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 5.99 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.97 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 222.45 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 212.80 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 116.26 | test_affinity_groups.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
    test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
    test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---