You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/04 17:26:47 UTC

[GitHub] [commons-jexl] csamak opened a new pull request #57: More parser compatibility fixes for JavaCC/JJTree

csamak opened a new pull request #57:
URL: https://github.com/apache/commons-jexl/pull/57


   I'm not sure why STATIC=false was commented out? Without it, generating
   the parser with JavaCC does not work.
   
   The Parser constructor taking String throws ParseException (a checked
   exception) when generated with JavaCC. I'm not sure why, but the
   StringProvider exception does not.
   
   For the pragmaValue changes, unreachable statements were generated. See
   http://consoliii.blogspot.com/2014/05/javacc-modern-mode-how-to-resolve.html
   
   With these changes I'm able to use JavaCC and everything passes again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-jexl] henrib merged pull request #57: More parser compatibility fixes for JavaCC/JJTree

Posted by GitBox <gi...@apache.org>.

henrib merged pull request #57:
URL: https://github.com/apache/commons-jexl/pull/57


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-jexl] coveralls commented on pull request #57: More parser compatibility fixes for JavaCC/JJTree

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #57:
URL: https://github.com/apache/commons-jexl/pull/57#issuecomment-854902123


   
   [![Coverage Status](https://coveralls.io/builds/40318027/badge)](https://coveralls.io/builds/40318027)
   
   Coverage remained the same at 87.042% when pulling **74dcd97613a047a7ff031cf7537f6878447fe761 on csamak:master** into **93f0a96be935a6a476147bee4e3913262c910f4f on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org