You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Thomas Rebele (Jira)" <ji...@apache.org> on 2023/05/04 16:03:00 UTC
[jira] [Updated] (CALCITE-5686) Generalize return types of the linq4j expression shuttle
[ https://issues.apache.org/jira/browse/CALCITE-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Rebele updated CALCITE-5686:
-----------------------------------
Description:
The following block in org.apache.calcite.linq4j.tree.Shuttle prevents replacing constants with other expressions:
{code:java}
public ConstantExpression visit(ConstantExpression constantExpression) {
return constantExpression;
} {code}
The return type of the corresponding accept function is more general:
{code:java}
@Override public Expression accept(Shuttle shuttle) {
return shuttle.visit(this);
} {code}
> Generalize return types of the linq4j expression shuttle
> --------------------------------------------------------
>
> Key: CALCITE-5686
> URL: https://issues.apache.org/jira/browse/CALCITE-5686
> Project: Calcite
> Issue Type: Improvement
> Reporter: Thomas Rebele
> Assignee: Thomas Rebele
> Priority: Major
> Fix For: 1.35.0
>
>
> The following block in org.apache.calcite.linq4j.tree.Shuttle prevents replacing constants with other expressions:
> {code:java}
> public ConstantExpression visit(ConstantExpression constantExpression) {
> return constantExpression;
> } {code}
> The return type of the corresponding accept function is more general:
> {code:java}
> @Override public Expression accept(Shuttle shuttle) {
> return shuttle.visit(this);
> } {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)