[PATCH][4.1.9] Jasper bug - script variables not synchronized

[David Shanahan <da...@biosjp.com>]

OK I have got my build working. Wasn't as painful
as it initially looked. 

This patch works for me (fixes the problems mentioned below).
And at least I don't think it breaks anything (ahem, I think).

With this problem out of the way Tomcat 4.1.9 works nicely for me.

Be great to see a release soon.

Thanks to everyone for their efforts on Tomcat !


-----Original Message-----
From: David Shanahan 
Sent: Monday, August 12, 2002 3:54 PM
To: 'tomcat-dev@jakarta.apache.org'
Subject: RE: [4.1.9] New test milestone released



There is a bug in 4.1.9 (a Jasper bug) that breaks my
application completely.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11552

We use custom tags that do iteration (they implement IterationTag)
but do not modify their content so they do not implement BodyTag.

The latest versions of Jasper2 generates code which only synchronizes
script variables before the first iteration of the tag. (ie before the do {}
while() loop).

There is also another bug whereby if a BodyTag returns EVAL_BODY_INCLUDE,
the script variables will not be synchronized at ALL for the first
iteration.

The problem is in org.apache.jasper.Generator.java. The generated code
for a tag that implements IterationTag synchronizes variables before the tag
loop but not inside it (even for NESTED scoped variables). 

Also for BodyTags that return EVAL_BODY_INCLUDE, the synchronization 
for the first iteration is skipped completely because it gets placed
together
in the same block of code that sets up the BodyContent buffer and that gets
skipped on EVAL_BODY_INCLUDE.

I have submitted some patches that move the variable synchronization into
the body of the loop for IterationTags and BodyTags. I think this should fix
the 
problem but I haven't got round to setting up a build environment yet.
(sorry). 
Doing that now.

If someone could take a look at this it would be much appreciated.
Thanks.


> -----Original Message-----
> From: Remy Maucherat [mailto:remm@apache.org]
> Sent: Sunday, August 11, 2002 1:21 AM
> To: Tomcat Developers List; Tomcat Users List
> Subject: [4.1.9] New test milestone released
> 
> 
> A new test milestone of Tomcat 4.1 has just been released.
> 
> Downloads:
> http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.9/
> 
> Significant changes over 4.1.8 Beta include:
> - Jasper 2 bugfixes
> - Catalina classloader bugfixes
> - Coyote HTTP/1.1 fixes
> - Updated commons-dbcp connection pool
> 
> The list of changes is available in the release notes.
> 
> Remy
> 
> 
> --
> To unsubscribe, e-mail:   
> <ma...@jakarta.apache.org>
> For additional commands, e-mail: 
> <ma...@jakarta.apache.org>
> 

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>