You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by ne...@apache.org on 2017/01/13 23:36:04 UTC
[08/29] incubator-trafficcontrol git commit: Remove unnecessary
global errorMessage variable, use fmt.Printf() instead
Remove unnecessary global errorMessage variable, use fmt.Printf() instead
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/commit/8bdb8bee
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/tree/8bdb8bee
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/diff/8bdb8bee
Branch: refs/heads/master
Commit: 8bdb8beea4e1317b5acd9947915379c93d37358f
Parents: 29c3206
Author: sbogacz <sb...@zvelo.com>
Authored: Fri Jan 6 19:25:38 2017 -0700
Committer: David Neuman <da...@gmail.com>
Committed: Fri Jan 13 23:33:56 2017 +0000
----------------------------------------------------------------------
traffic_stats/influxdb_tools/sync_ts_databases.go | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/blob/8bdb8bee/traffic_stats/influxdb_tools/sync_ts_databases.go
----------------------------------------------------------------------
diff --git a/traffic_stats/influxdb_tools/sync_ts_databases.go b/traffic_stats/influxdb_tools/sync_ts_databases.go
index ca6b845..55e6878 100644
--- a/traffic_stats/influxdb_tools/sync_ts_databases.go
+++ b/traffic_stats/influxdb_tools/sync_ts_databases.go
@@ -56,8 +56,6 @@ type dailyStats struct {
value float64
}
-var errorMessage string
-
func syncFlags() []cli.Flag {
return []cli.Flag{
cli.StringFlag{
@@ -251,8 +249,7 @@ func syncCacheStat(sourceClient influx.Client, targetClient influx.Client, statN
//get values from target DB
targetRes, err := queryDB(targetClient, queryString, db)
if err != nil {
- errorMessage = fmt.Sprintf("An error occured getting %s record from target db: %v\n", statName, err)
- fmt.Println(errorMessage)
+ fmt.Printf("An error occured getting %s record from target db: %v\n", statName, err)
return
}
targetStats := getCacheStats(targetRes)
@@ -306,16 +303,14 @@ func syncDeliveryServiceStat(sourceClient influx.Client, targetClient influx.Cli
fmt.Println("queryString ", queryString)
res, err := queryDB(sourceClient, queryString, db)
if err != nil {
- errorMessage = fmt.Sprintf("An error occured getting %s records from sourceDb: %v\n", statName, err)
- fmt.Println(errorMessage)
+ fmt.Printf("An error occured getting %s records from sourceDb: %v\n", statName, err)
return
}
sourceStats := getDeliveryServiceStats(res)
// get value from target DB
targetRes, err := queryDB(targetClient, queryString, db)
if err != nil {
- errorMessage = fmt.Sprintf("An error occured getting %s record from target db: %v\n", statName, err)
- fmt.Println(errorMessage)
+ fmt.Printf("An error occured getting %s record from target db: %v\n", statName, err)
return
}
targetStats := getDeliveryServiceStats(targetRes)
@@ -365,16 +360,14 @@ func syncDailyStat(sourceClient influx.Client, targetClient influx.Client, statN
}
res, err := queryDB(sourceClient, queryString, db)
if err != nil {
- errorMessage = fmt.Sprintf("An error occured getting %s records from sourceDb: %v\n", statName, err)
- fmt.Println(errorMessage)
+ fmt.Printf("An error occured getting %s records from sourceDb: %v\n", statName, err)
return
}
sourceStats := getDailyStats(res)
// get value from target DB
targetRes, err := queryDB(targetClient, queryString, db)
if err != nil {
- errorMessage = fmt.Sprintf("An error occured getting %s record from target db: %v\n", statName, err)
- fmt.Println(errorMessage)
+ fmt.Printf("An error occured getting %s record from target db: %v\n", statName, err)
return
}
targetStats := getDailyStats(targetRes)