You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/03 13:16:09 UTC
[GitHub] [dubbo] AlbumenJ commented on a change in pull request #8671: [3.0] Enhance: Remove similar code
AlbumenJ commented on a change in pull request #8671:
URL: https://github.com/apache/dubbo/pull/8671#discussion_r701882591
##########
File path: dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/util/NacosNamingServiceUtils.java
##########
@@ -133,7 +133,7 @@ private static void setServerAddr(URL url, Properties properties) {
}
private static void setProperties(URL url, Properties properties) {
- putPropertyIfAbsent(url, properties, NACOS_NAMING_LOG_NAME);
+ putPropertyIfAbsent(url, properties, NACOS_NAMING_LOG_NAME, null);
Review comment:
Also refer to Integration Tests
##########
File path: dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/util/NacosNamingServiceUtils.java
##########
@@ -133,7 +133,7 @@ private static void setServerAddr(URL url, Properties properties) {
}
private static void setProperties(URL url, Properties properties) {
- putPropertyIfAbsent(url, properties, NACOS_NAMING_LOG_NAME);
+ putPropertyIfAbsent(url, properties, NACOS_NAMING_LOG_NAME, null);
Review comment:
`null` should not be default value here. We should not call `properties.setProperty` with null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org