[GitHub] [druid] clintropolis commented on a change in pull request #12132: fix delegated smoosh writer and some new facilities for segment writeout medium

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #12132:
URL: https://github.com/apache/druid/pull/12132#discussion_r781688853



##########
File path: core/src/main/java/org/apache/druid/java/util/common/io/smoosh/FileSmoosher.java
##########
@@ -82,6 +84,10 @@
   private List<File> completedFiles = new ArrayList<>();
   // list of files in process writing content using delegated smooshedWriter.
   private List<File> filesInProcess = new ArrayList<>();
+  // delegated smooshedWriter creates a new temporary file per file added. we use a counter to name these temporary
+  // files, and map the file number to the file name so we don't have to escape the file names (e.g. names with '/')
+  private int delegateFileCounter = 0;

Review comment:
       this class definitely isn't thread-safe, but i don't have a strong preference either way so went ahead and changed it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org