[jira] Issue Comment Edited: (DERBY-3489) Error message XRE04 does not include the right port number.

["Øystein Grøvlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585073#action_12585073 ] 

oysteing edited comment on DERBY-3489 at 4/3/08 5:32 AM:
----------------------------------------------------------------

Thanks for the patch, Narayanan.  It basically looks good.  I have only a
few comments:

 - SlaveController#boot:  Need to check for port being null.  Check
   what happens if you do startSlave without specifying port.
   (Evidently the test suite does not test that.  Such a test would be
   good). 

 - ReplicationMessageReceive constructor: Parameter dbname is no
   longer used

 - ReplicationMessageReceive: Import of UnknownHostException no longer
   necessary. 

 - MessageId: Does not seem to contain any significant change.



      was (Author: oysteing):
    Thanks for the patch, Narayanan.  It basically looks.  I have only a
few comments:

 - SlaveController#boot:  Need to check for port being null.  Check
   what happens if you do startSlave without specifying port.
   (Evidently the test suite does not test that.  Such a test would be
   good). 

 - ReplicationMessageReceive constructor: Parameter dbname is no
   longer used

 - ReplicationMessageReceive: Import of UnknownHostException no longer
   necessary. 

 - MessageId: Does not seem to contain any significant change.


  
> Error message XRE04 does not include the right port number.
> -----------------------------------------------------------
>
>                 Key: DERBY-3489
>                 URL: https://issues.apache.org/jira/browse/DERBY-3489
>             Project: Derby
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 10.4.0.0
>            Reporter: Øystein Grøvlen
>            Assignee: V.Narayanan
>         Attachments: Derby3489_1.diff, Derby3489_1.stat, Derby3489_2.diff, Derby3489_2.stat
>
>
> If the master is not able to connect to the slave, the error messages does not include the right port number:
> ij> connect 'jdbc:derby:masterDB;user=oystein;password=pass;startMaster=true;slaveHost=localhost;slavePort=9901';
> ERROR XRE04: Could not establish a connection to the peer of the replicated database 'masterDB' on address 'localhost:-1'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.