You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "scala-steward-asf[bot] (via GitHub)" <gi...@apache.org> on 2024/06/16 00:13:11 UTC
[PR] Update ecs to 2.26.3 [pekko-management]
scala-steward-asf[bot] opened a new pull request, #259:
URL: https://github.com/apache/pekko-management/pull/259
## About this PR
📦 Updates software.amazon.awssdk:ecs from `2.25.70` to `2.26.3`
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/767fcfecbfd53c507152f6cf15c846176bae561d/docs/repo-specific-configuration.md) file.
_Have a fantastic day writing Scala!_
<details>
<summary>âš™ Adjust future updates</summary>
Add this to your `.scala-steward.conf` file to ignore future updates of this dependency:
```
updates.ignore = [ { groupId = "software.amazon.awssdk", artifactId = "ecs" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "software.amazon.awssdk", artifactId = "ecs" }
}]
```
</details>
<sup>
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1
</sup>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update ecs to 2.26.3 [pekko-management]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #259:
URL: https://github.com/apache/pekko-management/pull/259#discussion_r1642658599
##########
discovery-aws-api-async/src/main/scala/org/apache/pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala:
##########
@@ -54,7 +54,8 @@ class AsyncEcsTaskSetDiscovery(system: ActorSystem) extends ServiceDiscovery {
private val cluster = config.getString("cluster")
private lazy val ecsClient = {
- val conf = ClientOverrideConfiguration.builder().retryPolicy(RetryPolicy.none).build()
+ val retryStrategy = DefaultStandardRetryStrategy.builder().maxAttempts(0).build()
Review Comment:
lgtm
And I understand that `maxAttempts(0)` equals to `RetryPolicy.none`, can retry be supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update ecs to 2.26.3 [pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #259:
URL: https://github.com/apache/pekko-management/pull/259#issuecomment-2173947619
The retries were disabled by https://github.com/akka/akka-management/pull/201
We probably want to keep this.
The AWS SDK has deprecated the code that we use and I have modified this PR to use the new API for retries.
@raboof @samueleresca @mdedetrich @He-Pin @Roiocam does my retry change look ok - I have checked the AWS SDK code and this is the closest that I can find for a Do Not Retry Strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update ecs to 2.26.3 [pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #259:
URL: https://github.com/apache/pekko-management/pull/259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update ecs to 2.26.3 [pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #259:
URL: https://github.com/apache/pekko-management/pull/259#issuecomment-2171126135
We use a deprecated method to set a RetryPolicy of none. Should we disable retries - seems like a bad idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update ecs to 2.26.3 [pekko-management]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #259:
URL: https://github.com/apache/pekko-management/pull/259#issuecomment-2176151864
Looks good. Yes, we want to keep the retry disabled as it is retried upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update ecs to 2.26.3 [pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #259:
URL: https://github.com/apache/pekko-management/pull/259#issuecomment-2176039799
> akka/akka-management#201
That is my interpretation of what is in https://github.com/akka/akka-management/pull/201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update ecs to 2.26.3 [pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #259:
URL: https://github.com/apache/pekko-management/pull/259#discussion_r1642662092
##########
discovery-aws-api-async/src/main/scala/org/apache/pekko/discovery/awsapi/ecs/AsyncEcsTaskSetDiscovery.scala:
##########
@@ -54,7 +54,8 @@ class AsyncEcsTaskSetDiscovery(system: ActorSystem) extends ServiceDiscovery {
private val cluster = config.getString("cluster")
private lazy val ecsClient = {
- val conf = ClientOverrideConfiguration.builder().retryPolicy(RetryPolicy.none).build()
+ val retryStrategy = DefaultStandardRetryStrategy.builder().maxAttempts(0).build()
Review Comment:
That's the point I made in https://github.com/apache/pekko-management/pull/259#issuecomment-2171126135
I'd prefer to remove this retryStrategy and use the default retry setup - or to explicitly add a retry strategy that actually retries.
But this requires discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org