You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by pellmont <gi...@git.apache.org> on 2017/10/15 13:17:24 UTC
[GitHub] zeppelin pull request #2624: [ZEPPELIN-2965] Add code completion for livy in...
GitHub user pellmont opened a pull request:
https://github.com/apache/zeppelin/pull/2624
[ZEPPELIN-2965] Add code completion for livy interpreter
### What is this PR for?
This PR adds code autocompletion feature to LivyInterpreter.
Livy version 0.5 will have an auto completion API.
### What type of PR is it?
Feature
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-2965] https://issues.apache.org/jira/browse/ZEPPELIN-2965
### How should this be tested?
Pulled out server calls to a separate class to support proper unit-testing with mockito.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pellmont/zeppelin ZEPPELIN-2965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2624
----
commit 94858b5de0129d77a125adfb9157dcc2f6171508
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-09-03T06:57:34Z
ZEPPELIN-204 make scala code completion work again
commit 4b594daf5f388135eb1df33b48c071d06cffe543
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-09-06T18:15:03Z
Merge branch 'master' of git@github.com:apache/zeppelin.git
commit ba526049e02275266681ec372edfc5263ec1c3c5
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-09-06T21:01:12Z
ZEPPELIN-204 different treatment for scala 2.10
multiline completion not supported
commit 5f8d07c63a320f8a0a7e3a6bf31f343f88b29488
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-09-07T18:48:29Z
ZEPPELIN-204 fixed completion for scala 2.11 < 2.11.8
Limitations are the same as for scala 2.10: Will only consider the
current line rather than the whole code block.
commit 330bf8be378e10128a270a396a3bda11edab80c9
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-09-09T12:56:49Z
Merge branch 'master' of git@github.com:apache/zeppelin.git
commit 5f7169eab87dbf6a2696d9c85f695127f135cca9
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-09-28T19:08:41Z
Merge branch 'master' of git@github.com:apache/zeppelin.git
commit a916278756a419df3451d50b67f1cd55f2e2e1b4
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-10-05T12:34:56Z
ZEPPELIN-2965 code completion for livy
commit 94244963fb650d8e6a66e496c13eb0afc9fac3b1
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-10-05T19:15:19Z
Merge remote-tracking branch 'apache/zeppelin/master' into ZEPPELIN-2965
commit 6c840dc8ef90e2daffba2e3cceb3f24dd55ca683
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-10-09T07:16:42Z
Merge branch 'master' of git@github.com:apache/zeppelin.git into ZEPPELIN-2965
commit 1a03f4b6c27c9375d1e32c366add72fe6a60b7d1
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-10-15T13:13:35Z
Merge remote-tracking branch 'apache/zeppelin/master' into ZEPPELIN-2965
Conflicts:
livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterpreter.java
----
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by pellmont <gi...@git.apache.org>.
Github user pellmont commented on the issue:
https://github.com/apache/zeppelin/pull/2624
Of course I did :-)
But:
- Code-Completion is by ctrl-. (as before ZEPPELIN-277). If it should be tab it has to be configured probably in livy/interpreter-settings.json
- You need a fresh 0.5.0-SNAPSHOT version of livy (since 0.5.0 with LIVY-7 is not yet released). But code completion in LivyInterpreter won't produce any errors if the feature is not available in livy...
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
@pellmont CI is failed, could you rebase and rerun it ?
---
[GitHub] zeppelin pull request #2624: [ZEPPELIN-2965] Add code completion for livy in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2624
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
Thanks for the contribution @pellmont , but I don't think it make sense to make so large change just for unit test. Actually livy interpreter can run integration which is much better than unit test to guarantee the function of livy interpreter.
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2624
This commit seems broke Tab to indent text behavior.
https://issues.apache.org/jira/browse/ZEPPELIN-3253
---
[GitHub] zeppelin pull request #2624: [ZEPPELIN-2965] Add code completion for livy in...
Posted by pellmont <gi...@git.apache.org>.
GitHub user pellmont reopened a pull request:
https://github.com/apache/zeppelin/pull/2624
[ZEPPELIN-2965] Add code completion for livy interpreter
### What is this PR for?
This PR adds code autocompletion feature to LivyInterpreter.
Livy version 0.5 will have an auto completion API.
### What type of PR is it?
Feature
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-2965] https://issues.apache.org/jira/browse/ZEPPELIN-2965
### How should this be tested?
Pulled out server calls to a separate class to support proper unit-testing with mockito.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pellmont/zeppelin ZEPPELIN-2965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2624
----
commit 32b3c6b81abc4e6d05701af477e2ecb960d3556a
Author: Pascal Pellmont <gi...@ppo2.ch>
Date: 2017-10-16T18:04:07Z
ZEPPELIN-2965 code completion for livy
----
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
@pellmont Could you update interpreter-setting.json to make tab as the completion key ? Because livy should be consistent with the built-in spark interpreter.
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by pellmont <gi...@git.apache.org>.
Github user pellmont commented on the issue:
https://github.com/apache/zeppelin/pull/2624
welcome @zjffdu.
Actually I am not a big fan of integration tests, because they are usually slow and brittle. In my opinion integration tests should be used sparely, the main functionality should be tested by unit tests.
Also the way I put it now separates the code for making the HTTP call of the actual features of the livy API.
But if you prefer, I can put everything into BaseLivyInterpreter...
---
[GitHub] zeppelin pull request #2624: [ZEPPELIN-2965] Add code completion for livy in...
Posted by pellmont <gi...@git.apache.org>.
Github user pellmont closed the pull request at:
https://github.com/apache/zeppelin/pull/2624
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
ping @pellmont I also left some comments, in case you miss it.
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
@pellmont have you verified in from end to end ? It seems doesn't work for me when I type tab in frontend. I think it may need frontend change as well.
---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2624
IMHO，it is better to have integration test for interpreter. Because interpreter is usually 3rd party library outside zeppelin. Unit test usually has many assumption which may not be true in real scenario. While integration test can simulate the real scenario.
---