[GitHub] [netbeans] eirikbakke commented on issue #1771: [NETBEANS-3428] FlatLaf: UI delegates for editor and view tabs in main window

[GitBox <gi...@apache.org>]

eirikbakke commented on issue #1771: [NETBEANS-3428] FlatLaf: UI delegates for editor and view tabs in main window
URL: https://github.com/apache/netbeans/pull/1771#issuecomment-565105696
 
 
   @lkishalmi @DevCharly I'm happy with merging--future work can be added in fresh commits.
   
   @DevCharly
   On the "minimize" icon discussion: I think the first three screenshots in your comment were OK. Perhaps you can compensate for thinness by making sure the line fills the entire device pixel width available to the icon. Compare for instance with the "minimize" button shown on Windows 10 on the top-right corner of any OS-painted window.
   
   It still looks vertically misaligned next to the X--it should be like an underscore, not a hyphen (so "X _", not "X -").
   
   On the editor tab height discussion: Most screens are widescreen these days, which means vertical space is at a real premium. A Retina MacBook Pro with a 2560x1600 device pixel resolution effectively ends up having only 800 logical pixels available in the vertical direction--30% _less_ than than the laptop I had back in 2004! For this reason I would encourage keeping things tight in the vertical direction, at least in the editor area.
   
   On the tab border discussion: The hover effect is nice, but how does the user know where to aim the mouse when moving it towards a tab? It's not clear where the boundary between one tab and the next is. And in the editor tabs, when there are 3-4 adjacent non-selected tabs open, it will not be immediately visually clear whether the "X" belongs to the tab to the left or the right.
   
   In the screenshots on https://www.formdev.com/flatlaf, the borderless tab works well, because each tab is only a text component. I think the presence of an X button and an icon for each tab makes the borderless approach less feasible. You could add more horizontal space between the tabs, but that would decrease the number of tabs the user can see at once (and I, for one, frequently have 15-20 tabs open).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists