You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/01/06 21:58:23 UTC

Re: [PR] GH-39303: [Archery][Benchmarking] Allow setting C++ repetition min time [arrow]

kou commented on code in PR #39324:
URL: https://github.com/apache/arrow/pull/39324#discussion_r1443863862


##########
dev/archery/requirements-test.txt:
##########
@@ -0,0 +1,2 @@
+pytest

Review Comment:
   > Well, apparently requirements files are excluded from the RAT checks?
   
   In general, I think that we should use the RAT checks as much as possible for safety. 
   
   > I presume comments are not supported in those files.
   
   https://github.com/apache/arrow/blob/main/docs/requirements.txt uses comment. So we may be able to use comment here too. If we can't, I'm OK with excluding from the RAT checks.
   
   We can defer this to another PR if needed.
   I'll merge this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org