You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/06/06 01:28:06 UTC
Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/
-----------------------------------------------------------
Review request for drill, Aman Sinha and Jinfeng Ni.
Bugs: DRILL-1169
https://issues.apache.org/jira/browse/DRILL-1169
Repository: drill-git
Description
-------
Use Union-All followed by Aggregate to implement Union-Distinct
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDistinctUnionByUnionAll.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/35163/diff/
Testing
-------
all the required tests
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On June 9, 2015, 2:15 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDistinctUnionByUnionAll.java, line 34
> > <https://reviews.apache.org/r/35163/diff/1/?file=980272#file980272line34>
> >
> > Have you tried using Calcite's UnionToDistinctRule ?
Make sense ... Calcite already made the work for us...
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/#review87120
-----------------------------------------------------------
On June 9, 2015, 5:37 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35163/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 5:37 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-1169
> https://issues.apache.org/jira/browse/DRILL-1169
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Use Union-All followed by Aggregate to implement Union-Distinct
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
> exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35163/diff/
>
>
> Testing
> -------
>
> all the required tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/#review87120
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDistinctUnionByUnionAll.java
<https://reviews.apache.org/r/35163/#comment139445>
Have you tried using Calcite's UnionToDistinctRule ?
- Aman Sinha
On June 5, 2015, 11:28 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35163/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 11:28 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-1169
> https://issues.apache.org/jira/browse/DRILL-1169
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Use Union-All followed by Aggregate to implement Union-Distinct
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDistinctUnionByUnionAll.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
> exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35163/diff/
>
>
> Testing
> -------
>
> all the required tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/#review87636
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On June 11, 2015, 5:56 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35163/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 5:56 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-1169
> https://issues.apache.org/jira/browse/DRILL-1169
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Use Union-All followed by Aggregate to implement Union-Distinct
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionAllRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRule.java e0f9e2d
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java b92de3b
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
> exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35163/diff/
>
>
> Testing
> -------
>
> all the required tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/
-----------------------------------------------------------
(Updated June 11, 2015, 5:56 p.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
New patch
Bugs: DRILL-1169
https://issues.apache.org/jira/browse/DRILL-1169
Repository: drill-git
Description
-------
Use Union-All followed by Aggregate to implement Union-Distinct
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionAllRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRule.java e0f9e2d
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java b92de3b
exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/35163/diff/
Testing
-------
all the required tests
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On June 11, 2015, 12:24 a.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java, line 60
> > <https://reviews.apache.org/r/35163/diff/2/?file=981609#file981609line60>
> >
> > I think you should modify the DrillUnionRule to handle the distinct vs. non-distinct case rather than changing the cost function here.
Correct the code according to the comment;
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/#review87496
-----------------------------------------------------------
On June 9, 2015, 5:37 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35163/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 5:37 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-1169
> https://issues.apache.org/jira/browse/DRILL-1169
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Use Union-All followed by Aggregate to implement Union-Distinct
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
> exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35163/diff/
>
>
> Testing
> -------
>
> all the required tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/#review87496
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java
<https://reviews.apache.org/r/35163/#comment139841>
I think you should modify the DrillUnionRule to handle the distinct vs. non-distinct case rather than changing the cost function here.
- Aman Sinha
On June 9, 2015, 5:37 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35163/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 5:37 p.m.)
>
>
> Review request for drill, Aman Sinha and Jinfeng Ni.
>
>
> Bugs: DRILL-1169
> https://issues.apache.org/jira/browse/DRILL-1169
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Use Union-All followed by Aggregate to implement Union-Distinct
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
> exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
> exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
> exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35163/diff/
>
>
> Testing
> -------
>
> all the required tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct
type)
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35163/
-----------------------------------------------------------
(Updated June 9, 2015, 5:37 p.m.)
Review request for drill, Aman Sinha and Jinfeng Ni.
Changes
-------
Use Calcite's UnionToDistinctRule
Bugs: DRILL-1169
https://issues.apache.org/jira/browse/DRILL-1169
Repository: drill-git
Description
-------
Use Union-All followed by Aggregate to implement Union-Distinct
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 655ad92
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java 566c558
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java f1ec851
exec/java-exec/src/test/java/org/apache/drill/TestDisabledFunctionality.java adbf653
exec/java-exec/src/test/java/org/apache/drill/TestUnionDistinct.java PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q10.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q11.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q12.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q13.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q14.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q15.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q16.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q17.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q18_3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q3.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q4.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q5.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q6_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q7.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q8.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/q9.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_1.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testAggregationOnUnionDistinctOperator_2.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectDownOverUnionDistinctImplicitCasting.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectFiltertPushDownOverUnionDistinct.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownOverUnionDistinctWithoutProject.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectPushDownProjectColumnReorderingAndAlias.tsv PRE-CREATION
exec/java-exec/src/test/resources/testframework/TestUnionDistinctQueries/testProjectWithExpressionPushDownOverUnionDistinct.tsv PRE-CREATION
Diff: https://reviews.apache.org/r/35163/diff/
Testing
-------
all the required tests
Thanks,
Sean Hsuan-Yi Chu