You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/24 14:02:43 UTC

[GitHub] [spark] Yaohua628 opened a new pull request #35650: [SPARK-38314][SQL] Fix of failing to read parquet files after writing the hidden file metadata in

Yaohua628 opened a new pull request #35650:
URL: https://github.com/apache/spark/pull/35650


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   Selecting and then writing df containing hidden file metadata column `_metadata` into a file format like `parquet`, `delta` will still keep the internal `Attribute` metadata information. Then when reading those `parquet`, `delta` files again, it will actually break the code, because it wrongly thinks user data schema`_metadata` is a hidden file source metadata column. 
   
   ```
   // prepare a file source df
   df.select("*", "_metadata")
     .write.format("parquet").save(path)
   spark.read.format("parquet").load(path)
     .select("*").show()
   ```
   This PR fixes this by cleaning up any remaining metadata information of output columns.
   
   ### Why are the changes needed?
   Bugfix
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   A new UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yaohua628 commented on pull request #35650: [SPARK-38314][SQL] Fix of failing to read parquet files after writing the hidden file metadata in

Posted by GitBox <gi...@apache.org>.
Yaohua628 commented on pull request #35650:
URL: https://github.com/apache/spark/pull/35650#issuecomment-1053847413


   @cloud-fan hi Wenchen, are we ready to merge this fix? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yaohua628 commented on pull request #35650: [SPARK-38314][SQL] Fix of failing to read parquet files after writing the hidden file metadata in

Posted by GitBox <gi...@apache.org>.
Yaohua628 commented on pull request #35650:
URL: https://github.com/apache/spark/pull/35650#issuecomment-1049892331


   @cloud-fan please take a look whenever you have a chance, thanks a lot, appreciate the help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #35650: [SPARK-38314][SQL] Fix of failing to read parquet files after writing the hidden file metadata in

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35650:
URL: https://github.com/apache/spark/pull/35650#issuecomment-1054175747


   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #35650: [SPARK-38314][SQL] Fix of failing to read parquet files after writing the hidden file metadata in

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35650:
URL: https://github.com/apache/spark/pull/35650#issuecomment-1051320488


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #35650: [SPARK-38314][SQL] Fix of failing to read parquet files after writing the hidden file metadata in

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #35650:
URL: https://github.com/apache/spark/pull/35650


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org