[GitHub] [hbase] ndimiduk commented on a change in pull request #4221: Forward-port "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to master

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #4221:
URL: https://github.com/apache/hbase/pull/4221#discussion_r827333658



##########
File path: hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpointTracing.java
##########
@@ -228,7 +228,7 @@ public void onError(Throwable error) {
 
   @Test
   public void traceSyncTableEndpointCall() throws Exception {
-    final Connection connection = connectionRule.getConnection().toConnection();
+    final Connection connection = connectionRule.getSyncConnection();

Review comment:
       Hmm, you like that better? I think we use those words in our public API because we had to maintain backward compatibility, hence keeping `getConnection` and not renaming it to `getSyncConnection`. For this test code, I thought explicit names would be better. I don't feel strongly, was just my option as I wrote the code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org