You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by tandrup <gi...@git.apache.org> on 2017/04/24 13:19:43 UTC
[GitHub] storm pull request #2086: Adding extra Cassandra configuration parameters
GitHub user tandrup opened a pull request:
https://github.com/apache/storm/pull/2086
Adding extra Cassandra configuration parameters
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tandrup/storm cassandra-conf-updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2086.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2086
----
commit 7881e54e340de13fba52e742fdf84254b030af7f
Author: Mads Tandrup <ma...@maetzke-tandrup.dk>
Date: 2017-04-24T13:07:54Z
Adding extra configuration parameters
commit 54d86419c3c31e398996a53adde37fb2eaa54f33
Author: Mads Tandrup <ma...@maetzke-tandrup.dk>
Date: 2017-04-24T13:12:39Z
Avoid ignoring unrecoverable errors during prepare if it is not able to connect to Cassandra
commit 1ab480c17e90455d069ca1fb31b2de5af0e46515
Author: Mads Tandrup <ma...@maetzke-tandrup.dk>
Date: 2017-04-24T13:18:31Z
Add socket connect timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2086: Adding extra Cassandra configuration parameters
Posted by tandrup <gi...@git.apache.org>.
Github user tandrup commented on the issue:
https://github.com/apache/storm/pull/2086
@harshach OK. I was hoping my changes was small enough to fall into the _small patches_ category. I'll create a jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2086: STORM-2491: Adding extra Cassandra configuration paramete...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2086
overall LGTM. +1 .
@tandrup would like to see these configs documented here https://github.com/apache/storm/blob/master/external/storm-cassandra/README.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2086: STORM-2491: Adding extra Cassandra configuration paramete...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2086
@tandrup for small docs changes etc. we don't file JIRAs but this one had quite few changes good to have that in JIRA and subsequently in CHANGELOG.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2086: STORM-2491: Adding extra Cassandra configuration paramete...
Posted by tandrup <gi...@git.apache.org>.
Github user tandrup commented on the issue:
https://github.com/apache/storm/pull/2086
@harshach I've added the new configs to the existing README list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2086: Adding extra Cassandra configuration parameters
Posted by tandrup <gi...@git.apache.org>.
Github user tandrup commented on the issue:
https://github.com/apache/storm/pull/2086
It fails on
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project storm: Too many files with unapproved license: 3 See RAT report in: /home/travis/build/apache/storm/target/rat.txt -> [Help 1]
```
Do I need to do anything with licenses?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2086: STORM-2491: Adding extra Cassandra configuration p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2086
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2086: Adding extra Cassandra configuration parameters
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/2086
@tandrup can you please a file a JIRA https://issues.apache.org/jira/browse/ under STORM project. Also update the title of the JIRA and squash the commits in this PR. More details https://github.com/apache/storm/blob/master/DEVELOPER.md#contribute-code
https://github.com/apache/storm/blob/master/DEVELOPER.md#pull-requests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2086: STORM-2491: Adding extra Cassandra configuration paramete...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2086
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---