You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/10/21 06:00:16 UTC

[GitHub] [hadoop] bilaharith commented on a change in pull request #2343: HADOOP-17289 ABFS: Fixing the test case ITestAbfsNetworkStatistics#testAbfsHttpResponseStatistics

bilaharith commented on a change in pull request #2343:
URL: https://github.com/apache/hadoop/pull/2343#discussion_r509008689



##########
File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsNetworkStatistics.java
##########
@@ -223,13 +223,7 @@ public void testAbfsHttpResponseStatistics() throws IOException {
        *
        * bytes_received - This should be equal to bytes sent earlier.
        */
-      long extraCalls = 0;

Review comment:
       getResponsesBeforeTest will be the total number of calls before the open and read operations. Basically the removed part was buggy because here we do the calculation wrongly by including the extracalls which is already covered in the getResponsesBeforeTest.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org