[jira] [Comment Edited] (TEZ-886) Add @Nullable annotation at API level

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984957#comment-13984957 ] 

Bikas Saha edited comment on TEZ-886 at 4/29/14 11:32 PM:
----------------------------------------------------------

Minor comment.
These should probably not be null, right?
{code}-  public void setVertexLocationHint(VertexLocationHint locationHint);
+  public void setVertexLocationHint(@Nullable VertexLocationHint locationHint);
...
+  @Nullable
   public Input waitForAnyInputReady(Collection<Input> inputs) throws InterruptedException;
...
+  public void requestInitialMemory(long size, @Nullable MemoryUpdateCallback callbackHandler);
...
+  @Nullable
   @Override
   public ProcessorDescriptor getProcessorDescriptor() 
...
+  @Nullable
   @Override
   public Input waitForAnyInputReady(Collection<Input> inputs) throws InterruptedException {
     return inputReadyTracker.waitForAnyInputReady(inputs);
{code}


was (Author: bikassaha):
Minor comment.
This should probably not be null, right?
{code}-  public void setVertexLocationHint(VertexLocationHint locationHint);
+  public void setVertexLocationHint(@Nullable VertexLocationHint locationHint);{code}
...
+  @Nullable
   public Input waitForAnyInputReady(Collection<Input> inputs) throws InterruptedException;
...
+  public void requestInitialMemory(long size, @Nullable MemoryUpdateCallback callbackHandler);
...
+  @Nullable
   @Override
   public ProcessorDescriptor getProcessorDescriptor() 
...
+  @Nullable
   @Override
   public Input waitForAnyInputReady(Collection<Input> inputs) throws InterruptedException {
     return inputReadyTracker.waitForAnyInputReady(inputs);
{code}

> Add @Nullable annotation at API level
> -------------------------------------
>
>                 Key: TEZ-886
>                 URL: https://issues.apache.org/jira/browse/TEZ-886
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: TEZ-886.1.patch, TEZ-886.2.patch, TEZ-886.3.patch
>
>
> It's effective to avoid NPE by adding @Nullable annotation. This JIRA will be done after TEZ-884.



--
This message was sent by Atlassian JIRA
(v6.2#6252)