You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/05 11:56:49 UTC
[GitHub] [pulsar] lordcheng10 opened a new pull request, #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
lordcheng10 opened a new pull request, #16401:
URL: https://github.com/apache/pulsar/pull/16401
### Motivation
According to the current logic, if the number of bundles on a broker is 0, the broker will not participate in bundle allocation, so that the newly started broker will not be allocated to the bundle:
https://github.com/apache/pulsar/blob/da325fa64399642700d35b7d538a92b65c604bf5/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java#L78~82
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179635891
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186497879
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186798325
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187363252
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187557342
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186846101
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186511012
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1193020116
ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187096285
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1193471975
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1195614322
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179632720
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1177065353
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1189341062
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187919067
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188939970
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186846891
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186847236
@Jason918 PTAL，thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175040642
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175096266
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#discussion_r915385511
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java:
##########
@@ -76,7 +76,7 @@ public Multimap<String, String> findBundlesForUnloading(final LoadData loadData,
MutableDouble minThroughputRate = new MutableDouble(Integer.MAX_VALUE);
brokersData.forEach((broker, data) -> {
//broker with one bundle can't be considered for bundle unloading
- if (data.getLocalData().getBundles().size() <= 1) {
+ if (data.getLocalData().getBundles().size() == 1) {
Review Comment:
Fixed. PTAL,thanks! @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179632992
@Shoothzj PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1190297794
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1189367070
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187125155
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187181063
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188596577
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175038431
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175047153
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179652120
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1174976178
@hangc0276 @codelipenghui @Shoothzj @eolivelli PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179632656
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175785341
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186991392
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188596198
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1193048062
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1193472107
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186500243
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186549334
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186497655
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186522454
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186551496
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1181347093
> LGTM, Please add some unit test for this case.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175785179
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179635923
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187364244
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187779293
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187983082
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang merged pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
aloyszhang merged PR #16401:
URL: https://github.com/apache/pulsar/pull/16401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1191578723
@lordcheng10 When these CI passed, they can be merged. Not need always retry.
<img width="1093" alt="image" src="https://user-images.githubusercontent.com/33416836/180243232-dcd8e5ce-b1af-4430-a2df-36ade01b4d95.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188637074
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188842454
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1189344704
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187031619
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186513363
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175096384
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1176040902
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on a diff in pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#discussion_r915367651
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java:
##########
@@ -76,7 +76,7 @@ public Multimap<String, String> findBundlesForUnloading(final LoadData loadData,
MutableDouble minThroughputRate = new MutableDouble(Integer.MAX_VALUE);
brokersData.forEach((broker, data) -> {
//broker with one bundle can't be considered for bundle unloading
- if (data.getLocalData().getBundles().size() <= 1) {
+ if (data.getLocalData().getBundles().size() == 1) {
Review Comment:
It just selects bundles for unloading. If one broker with one or doesn't have any bundles, it will skip this cycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1191011099
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186457141
I added the corresponding test in UniformLoadShedderTest, please review again, thanks! @Jason918 @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186517207
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187124745
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188572722
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179470873
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179632708
@codelipenghui @eolivelli PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179635598
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1195611064
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1177222789
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188636400
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187368199
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186551367
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186546118
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1191750572
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1195616516
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187561612
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1196134761
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175341789
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175095669
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1180523835
> It will not affect the allocation. Here, it will affect the unload: if the previous nodes are relatively balanced, the new nodes will not trigger the unload. As a result, new nodes cannot be assigned bundles
OK, I see. The `maxMsgRate` and `minMsgRate` calculation should take the empty nodes into account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179482127
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1178849131
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179470767
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#discussion_r915370210
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java:
##########
@@ -76,7 +76,7 @@ public Multimap<String, String> findBundlesForUnloading(final LoadData loadData,
MutableDouble minThroughputRate = new MutableDouble(Integer.MAX_VALUE);
brokersData.forEach((broker, data) -> {
//broker with one bundle can't be considered for bundle unloading
- if (data.getLocalData().getBundles().size() <= 1) {
+ if (data.getLocalData().getBundles().size() == 1) {
Review Comment:
It is not only to choose overloaded brokers to unload, but also to choose low-loaded brokers to load.
Otherwise, a new broker cannot be assigned to the bundle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1175786821
@eolivelli @hangc0276 @codelipenghui PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#discussion_r915370210
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/UniformLoadShedder.java:
##########
@@ -76,7 +76,7 @@ public Multimap<String, String> findBundlesForUnloading(final LoadData loadData,
MutableDouble minThroughputRate = new MutableDouble(Integer.MAX_VALUE);
brokersData.forEach((broker, data) -> {
//broker with one bundle can't be considered for bundle unloading
- if (data.getLocalData().getBundles().size() <= 1) {
+ if (data.getLocalData().getBundles().size() == 1) {
Review Comment:
It is not only to choose overloaded brokers to unload, but also to choose low-loaded brokers to load.
Otherwise, a new broker cannot be assigned to the bundle. @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1178865376
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179756832
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179756871
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1179441885
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1180054294
> AFAIK, bundle assignment is implemented in `org.apache.pulsar.broker.loadbalance.impl.ModularLoadManagerImpl#selectBrokerForAssignment`. Can you point out how does `UniformLoadShedder ` affects bundle assignment?
It will not affect the allocation. Here, it will affect the unload: if the previous nodes are relatively balanced, the new nodes will not trigger the unload. As a result, new nodes cannot be assigned bundles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188636937
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186533514
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187314069
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187317445
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1187023315
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1188491131
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1186725899
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1191749820
> @lordcheng10 When these CI passed, they can be merged. Not need always retry.
>
> <img alt="image" width="1093" src="https://user-images.githubusercontent.com/33416836/180243232-dcd8e5ce-b1af-4430-a2df-36ade01b4d95.png">
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lordcheng10 commented on pull request #16401: [fix][broker] Fixed that newly added brokers cannot be assigned bundles for UniformLoadShedder
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #16401:
URL: https://github.com/apache/pulsar/pull/16401#issuecomment-1196135510
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org